Add icons to host bulk actions (theforeman#120)

* Add icons to host bulk actions * update review
stejskalleos · Jun 20, 2022 · f781cd8 · f781cd8
1 parent cd55c8e
commit f781cd8
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 2 deletions.
diff --git a/app/controllers/foreman_bootdisk/disks_controller.rb b/app/controllers/foreman_bootdisk/disks_controller.rb
@@ -123,14 +123,16 @@ def bootdisk_allowed_actions(host)
           title: title,
           link: "/bootdisk/disks/#{action}s/#{host.id}",
           disabled:  disable_full_host ? true : false,
-          description: disable_full_host ? _('Host is not in build mode') : nil
+          description: disable_full_host ? _('Host is not in build mode') : nil,
+          icon: action,
         }
       end
       return allowed unless User.current.allowed_to?({controller: 'foreman_bootdisk/disks', action: 'help'})
 
       allowed.push({
         title: _('Boot disk help'),
-        link: '/bootdisk/disks/help'
+        link: '/bootdisk/disks/help',
+        icon: 'help'
       })
     end
   end

diff --git a/webpack/src/extensions/host/HostBootdiskButtons.js b/webpack/src/extensions/host/HostBootdiskButtons.js
@@ -2,6 +2,12 @@ import React, { useEffect } from 'react';
 import { useSelector, useDispatch } from 'react-redux';
 
 import { DropdownItem, DropdownGroup } from '@patternfly/react-core';
+import {
+  BanIcon,
+  BuildIcon,
+  BuilderImageIcon,
+  OutlinedQuestionCircleIcon,
+} from '@patternfly/react-icons';
 
 import { get } from 'foremanReact/redux/API';
 import { foremanUrl } from 'foremanReact/common/helpers';
@@ -23,6 +29,19 @@ const HostBootdiskButtons = () => {
   const isLoading = useSelector(selectIsLoading);
   const options = useSelector(selectBootdiskOptions);
 
+  const iconComponent = icon => {
+    switch (icon) {
+      case 'host':
+        return <BuildIcon />;
+      case 'full_host':
+        return <BuilderImageIcon />;
+      case 'help':
+        return <OutlinedQuestionCircleIcon />;
+      default:
+        return null;
+    }
+  };
+
   useEffect(() => {
     dispatch(
       get({
@@ -40,6 +59,7 @@ const HostBootdiskButtons = () => {
         href={foremanUrl(action.link)}
         isDisabled={action.disabled}
         description={action.description}
+        icon={iconComponent(action.icon)}
       >
         {action.title}
       </DropdownItem>
@@ -55,6 +75,7 @@ const HostBootdiskButtons = () => {
           options.architectureName
         )}
         tooltipProps={{ entryDelay: 0, exitDelay: 0 }}
+        icon={<BanIcon />}
       >
         {__('Not available')}
       </DropdownItem>