[#21930] Keycard - Back up keycard #21990
Merged
+441
−135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (13)
|
flexsurfer
changed the title
Parveshdhull
approved these changes
Jan 28, 2025
flexsurfer
force-pushed
the
feature/Keycard---Back-up-keycard-#21930-
branch
from
71657f6 to
b81fbef
Compare
|
thank you @Parveshdhull |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
|
good catch @VolodLytvynenko , thanks, fixed |
flexsurfer
force-pushed
the
feature/Keycard---Back-up-keycard-#21930-
branch
from
9ad3436 to
c09a0d6
Compare
90% of end-end tests have passedFailed tests (5)Click to expandClass TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Class TestFallbackMultipleDevice:
Expected to fail tests (1)Click to expandClass TestCommunityMultipleDeviceMerged:
Passed tests (52)Click to expandClass TestActivityMultipleDevicePRTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestDeepLinksOneDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestFallbackMultipleDevice:
Class TestWalletOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestWalletMultipleDevice:
|
100% of end-end tests have passedPassed tests (10)Click to expandClass TestWalletMultipleDevice:
Class TestWalletOneDevice:
Class TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
|
ilmotta
approved these changes
Jan 30, 2025
There was a problem hiding this comment.
Thank you @flexsurfer. I did a quick review, no outstanding feedback on my part. PR LGTM, just left two comments. My comment about not calling rf/dispatch directly inside the event handler is the only one I think should be addressed.
| (fn [{:keys [db]} [pin]] | ||
| {:db (assoc-in db [:keycard :backup :pin] pin)})) | ||
|
|
||
| (defn- save-pin-and-navigate-to-phrase |
There was a problem hiding this comment.
A pattern I see in this namespace is that some functions could be actual events. For instance, the :on-success of :keycard/verify-pin could dispatch a new event, let's say named :keycard/save-pin-and-navigate-to-phrase. The small advantage is that you would then be able to use :fx to dispatch all effects instead of a series of imperative rf/dispatch calls, which is more friendly with the re-frame queue.
There was a problem hiding this comment.
thanks Icaro, i don't really think there is a difference in re-frame queue, but i really don't like using dispatch inside events, especially when there are only dispatches in the event
There was a problem hiding this comment.
Yeah @flexsurfer, the difference for the queue is certainly quite minimal to non-existent. Re-dispatching from event handlers like :on-success is helpful sometimes for devs using the REPL because they can easily re-run and debug the success handler directly and there's a bit more visibility in re-frisk. Both of these advantages are also quite small, but it's worth pointing out.
|
Hi @flexsurfer, Thank you for the fixes! Issue 1 is resolved. I haven’t finished testing yet, as this PR requires some time to cover all flows. Many flows are already completed, and I will finish the rest tomorrow. Just let you know the PR is in test process and everything look ok for now |
|
thanks @VolodLytvynenko , i forgot to mention, i haven't implemented |
|
@flexsurfer Sorry for the testing delay. I had to switch to another PR again. No issues from my side—this PR is ready to be merged. |
hi @flexsurfer Created it as a follow up #22013 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #21930
All flows have been implemented
Also Manage card in setting has been implemented
