Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove framework selector from docs #262

Open
oscartbeaumont opened this issue Mar 17, 2024 · 2 comments
Open

Remove framework selector from docs #262

oscartbeaumont opened this issue Mar 17, 2024 · 2 comments

Comments

@oscartbeaumont
Copy link
Member

Move it to actual command which is wayyy more common.

Also keep it in localStorage so it's the same if you come back.
@oscartbeaumont oscartbeaumont changed the title Remove framework selector Remove framework selector from docs Mar 17, 2024
@k-hashiura
Copy link

Hello, thank you for developing an amazing library.

While reading the documentation, I noticed a performance issue caused by an infinite loop in the framework selector section. It seems that the useEffect in Switchers.tsx is causing the infinite loop.

I am commenting here because this issue seems to be related to the problem described in this issue.

Apologies if you're already working on this.

@oscartbeaumont
Copy link
Member Author

Thanks for reporting. It is being tracked as #302, I just haven't had the time to fix it yet. Would love a PR if you have the time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oscartbeaumont @k-hashiura