Support parsing JSON output from mypy #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the pull request! Wow, I didn't know that mypy now supports JSON—that's awesome. I'll review the PR in the next few days when I have some free time. |
The documentation is thin on this https://mypy.readthedocs.io/en/stable/command_line.html#cmdoption-mypy-O This PR is looking good I think, it's probably more reliable overall |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for parsing JSON output from
mypy(as generated bymypy --output json). The may be a route to more robust parsing, especially relative to potential upstream text format changes.The main change is just updating the keys for the regex pattern to match what the JSON output provides. Testing on a local project the only change is the fingerprint.
I hope this change is welcome, am happy to change anything to suit the project, or have this rejected.