[Admin] Use Rails.application.mounted_helpers in base component #6039
+21
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
approved these changes
Dec 18, 2024
|
I don't understand if failures are strictly related but it seems like it's the case. |
|
Absolutely related. Will look into it tomorrow. |
mamhoff
force-pushed
the
use-mounted-helpers
branch
from
3c61e1a to
d72496f
Compare
|
The failures were related, and fixed by the second commit in this PR. |
mamhoff
force-pushed
the
use-mounted-helpers
branch
from
d72496f to
2013817
Compare
Rather than implementing routing proxies ourselves, we can use what Rails offers. Fixes solidusio#6038
Rails' `mounted_helpers` do not work when a component is initialized. They need to be called when the component is rendered. This change moves the rendering of tabs from initialization time to render time.
mamhoff
force-pushed
the
use-mounted-helpers
branch
from
2013817 to
c73de73
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6039 +/- ##
==========================================
- Coverage 89.59% 89.59% -0.01%
==========================================
Files 791 791
Lines 18269 18266 -3
==========================================
- Hits 16368 16365 -3
Misses 1901 1901 ☔ View full report in Codecov by Sentry. |
adammathys
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than implementing routing proxies ourselves, we can use what Rails offers.
Fixes #6038