Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file_upload_v2 => username #1580

Open
1 of 9 tasks
nick-youngblut opened this issue Oct 30, 2024 · 3 comments
Open
1 of 9 tasks

file_upload_v2 => username #1580

nick-youngblut opened this issue Oct 30, 2024 · 3 comments

Comments

@nick-youngblut
Copy link

The differences between chat_postMessage and file_upload_v2 lead to a sometimes frustrating dev experience. For instance, chat_postMessage includes the username parameter, allowing the developer to customize the username.

The file_upload_v2 function has no such parameter, so the bot's name cannot be customized, resulting in Slack threads with messages from the same bot, but named differently (custom username or the default name).

It would be very helpful if one could specify the username when executing file_upload_v2, as can be done for chat_postMessage.

There is also the difference between chat_postMessage and file_upload_v2 in regards to how channels can be specified. chat_postMessage allows channel names, while file_upload_v2 requires channel IDs. If one tries to use a channel name with file_upload_v2, the returned error is "channel not found" instead of a more informative error, such as "channel not found; note: this endpoint requires a channel ID".

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.models (UI component builders)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.rtm (RTM client)
  • slack_sdk.signature (Request Signature Verifier)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

@mwbrooks
Copy link
Member

Hey @nick-youngblut 🙇🏻 This is fantastic feedback, thank you!

From my understanding, these improvements around consistencies are at the Slack API level. We could consider patching them at the SDK level, but it would be a workaround that should be solved on the API.

I've shared your feedback internally with the Slack Platform team and I'm looking to see whether we can take it a step further than just reporting the feedback. So, I'll leave this issue open for a bit in case others would like to chime in!

Copy link

github-actions bot commented Dec 2, 2024

👋 It looks like this issue has been open for 30 days with no activity. We'll mark this as stale for now, and wait 10 days for an update or for further comment before closing this issue out. If you think this issue needs to be prioritized, please comment to get the thread going again! Maintainers also review issues marked as stale on a regular basis and comment or adjust status if the issue needs to be reprioritized.

@jfaldanam
Copy link

Just chiming in to express interest for this behavior, specially allowing the use of channel names ("#channel-name") instead of IDs when uploading files!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants