Fix oppia#6301: fixes Dev-mode label showing up for a brief amount of…

… time on page load. (oppia#6356) * added ng cloak to fix dev_mode showing up * modify DIV MODE def in constants.js * added the ng-cloak update in base_test.py * linting errors * lint errors * removed css, and replicated changed in tests
shashaBot · Mar 2, 2019 · 8171f30 · 8171f30
1 parent aa3aa04
commit 8171f30
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/core/controllers/base_test.py b/core/controllers/base_test.py
@@ -74,13 +74,15 @@ def test_dev_indicator_appears_in_dev_and_not_in_production(self):
 
         with self.swap(constants, 'DEV_MODE', True):
             response = self.get_html_response(feconf.LIBRARY_INDEX_URL)
-            self.assertIn('<div ng-if="DEV_MODE" class="oppia-dev-mode">',
-                          response.body)
+            self.assertIn(
+                '<div ng-if="DEV_MODE" class="oppia-dev-mode" ng-cloak>',
+                response.body)
 
         with self.swap(constants, 'DEV_MODE', False):
             response = self.get_html_response(feconf.LIBRARY_INDEX_URL)
-            self.assertIn('<div ng-if="DEV_MODE" class="oppia-dev-mode">',
-                          response.body)
+            self.assertIn(
+                '<div ng-if="DEV_MODE" class="oppia-dev-mode" ng-cloak>',
+                response.body)
 
     def test_that_no_get_results_in_500_error(self):
         """Test that no GET request results in a 500 error."""

diff --git a/core/templates/dev/head/pages/base.html b/core/templates/dev/head/pages/base.html
@@ -155,7 +155,7 @@ <h2>
         </div>
       </div>
 
-      <div ng-if="DEV_MODE" class="oppia-dev-mode">
+      <div ng-if="DEV_MODE" class="oppia-dev-mode" ng-cloak>
         Dev Mode
       </div>
 

diff --git a/core/tests/build_sources/templates/base.html b/core/tests/build_sources/templates/base.html
@@ -160,7 +160,7 @@ <h2>
         </div>
       </div>
 
-      <div ng-if="DEV_MODE" class="oppia-dev-mode">
+      <div ng-if="DEV_MODE" class="oppia-dev-mode" ng-cloak>
         Dev Mode
       </div>
-Original file line number
+Diff line change
@@ Expand Up / @@ -155,7 +155,7 @@ <h2> @@
             </div>
           </div>
-          <div ng-if="DEV_MODE" class="oppia-dev-mode">
+          <div ng-if="DEV_MODE" class="oppia-dev-mode" ng-cloak>
             Dev Mode
           </div>
@@ Expand Down @@