Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase of "Handle munmap over multiple VMAs" #2233

Merged
merged 6 commits into from
Jan 24, 2025

Conversation

kalaposfos13
Copy link
Contributor

Manually updated, since the original author hasn't been active lately.
Link to the original: #1822

@kalaposfos13 kalaposfos13 changed the title Rebase of #1822 Rebase of "Handle munmap over multiple VMAs" Jan 24, 2025
src/core/memory.cpp Outdated Show resolved Hide resolved
src/core/memory.cpp Outdated Show resolved Hide resolved
@squidbus
Copy link
Collaborator

Your code style changes to the function definitions at the end need the corresponding changes in memory.h as well

@georgemoralis
Copy link
Collaborator

ok some reviews on this?

Copy link
Collaborator

@squidbus squidbus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this and it seems to work, approach looks fine to me as well. Would like a second opinion on this though as it's a part of the code I'm less familiar with.

@georgemoralis
Copy link
Collaborator

looking good i vote for this

@georgemoralis georgemoralis merged commit 4f426b7 into shadps4-emu:main Jan 24, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants