-
|
I'm working on this issue and I've reached a roadblock. I want to modify the @jdm, @gterzian, @sagudev, or @mrobinson |
Beta Was this translation helpful? Give feedback.
Replies: 3 comments 3 replies
-
|
@nicoburns is working on this issue, so he is probably the best one to answer this question. |
Beta Was this translation helpful? Give feedback.
-
|
Oh yeah I did ask Nico about it so it would be good to get him in the discussion, thanks. Nico did mention that there is a I'm thinking that there should be a function like As for responding to the color scheme change event from the user's device/OS I am thinking there should be some functionality to modify a device or recreate a device directly. @mrobinson Then after setting the color scheme, would a reflow be required? This part I'm also unsure of because I don't know if there is an expectation of the layout changing when user color scheme preferences changes. |
Beta Was this translation helpful? Give feedback.
-
This is what I had in mind in the short term (and you might need similar for the viewport size). We are also looking into making it possible to mutate the Device directly. But I think that ought to be a separate change. |
Beta Was this translation helpful? Give feedback.
-
|
oh ok, if you're fine with this in the short term then I think have a working solution. I'm going to open a draft PR. There is a particular area concerning |
Beta Was this translation helpful? Give feedback.
-
|
I actually figured out the idea Nico was suggesting by making the theme change in the |
Beta Was this translation helpful? Give feedback.
-
|
Draft PR has been made #34532 @nicoburns |
Beta Was this translation helpful? Give feedback.
This is what I had in mind in the short term (and you might need similar for the viewport size). We are also looking into making it possible to mutate the Device directly. But I think that ought to be a separate change.