fix(Popover): to be attached in body when not in a modal #4646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c5846cc The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4646 +/- ##
==========================================
- Coverage 87.44% 87.41% -0.04%
==========================================
Files 335 335
Lines 12733 12740 +7
Branches 3528 3482 -46
==========================================
+ Hits 11135 11137 +2
- Misses 1598 1603 +5
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
lisalupi
approved these changes
Jan 8, 2025
radhi-nasser-scaleway
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Type
Summarise concisely:
What is expected?
Fix
<Popover />portal target to bedocument.bodyif not inside a modal.The popover needs space and attaching it to the direct parent can be tricky as the parent can have very narrow space. This way we ensure it has all the space available and in case it's inside a modal we attach it to the parent like we do before.