fix exportloopref linter

Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
sathisv3 · Apr 30, 2024 · f96d31e · f96d31e
1 parent 6fc8034
commit f96d31e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/.golangci.yaml b/.golangci.yaml
@@ -13,7 +13,6 @@ issues:
         - nilnil
         - nakedret
         - musttag
-        - exportloopref
         - gomoddirectives
       text: ".*"
     - linters:

diff --git a/test/integration/certificates/generates_new_private_key_per_request_test.go b/test/integration/certificates/generates_new_private_key_per_request_test.go
@@ -136,7 +136,7 @@ func TestGeneratesNewPrivateKeyIfMarkedInvalidRequest(t *testing.T) {
 		t.Fatalf("failed to update certificate: %v", err)
 	}
 
-	var secondReq *cmapi.CertificateRequest
+	var secondReq cmapi.CertificateRequest
 	if err := wait.PollUntilContextTimeout(ctx, time.Millisecond*500, time.Second*10, true, func(ctx context.Context) (bool, error) {
 		reqs, err := cmCl.CertmanagerV1().CertificateRequests(namespace).List(ctx, metav1.ListOptions{})
 		if err != nil {
@@ -151,7 +151,7 @@ func TestGeneratesNewPrivateKeyIfMarkedInvalidRequest(t *testing.T) {
 				continue
 			}
 
-			secondReq = &req // #nosec G601 -- False positive. See https://github.com/golang/go/discussions/56010
+			secondReq = req
 			return true, nil
 		}
 
@@ -273,7 +273,7 @@ func TestGeneratesNewPrivateKeyPerRequest(t *testing.T) {
 		t.Fatalf("failed to update certificate: %v", err)
 	}
 
-	var secondReq *cmapi.CertificateRequest
+	var secondReq cmapi.CertificateRequest
 	if err := wait.PollUntilContextTimeout(ctx, time.Millisecond*500, time.Second*10, true, func(ctx context.Context) (bool, error) {
 		reqs, err := cmCl.CertmanagerV1().CertificateRequests(namespace).List(ctx, metav1.ListOptions{})
 		if err != nil {
@@ -288,7 +288,7 @@ func TestGeneratesNewPrivateKeyPerRequest(t *testing.T) {
 				continue
 			}
 
-			secondReq = &req // #nosec G601 -- False positive. See https://github.com/golang/go/discussions/56010
+			secondReq = req
 			return true, nil
 		}