fix noctx linter

Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
sathisv3 · May 7, 2024 · de54201 · de54201
1 parent 52320fb
commit de54201
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/.golangci.yaml b/.golangci.yaml
@@ -8,7 +8,6 @@ issues:
         - exhaustive
         - nilerr
         - interfacebloat
-        - noctx
         - nilnil
         - nakedret
         - musttag

diff --git a/pkg/healthz/healthz_test.go b/pkg/healthz/healthz_test.go
@@ -277,7 +277,9 @@ func TestHealthzLivezLeaderElection(t *testing.T) {
 				lastResponseBody string
 			)
 			assert.Eventually(t, func() bool {
-				resp, err := http.Get(livezURL)
+				req, err := http.NewRequestWithContext(ctx, http.MethodGet, livezURL, nil)
+				require.NoError(t, err)
+				resp, err := http.DefaultClient.Do(req)
 				require.NoError(t, err)
 				defer func() {
 					require.NoError(t, resp.Body.Close())

diff --git a/test/integration/certificates/metrics_controller_test.go b/test/integration/certificates/metrics_controller_test.go
@@ -130,7 +130,11 @@ func TestMetricsController(t *testing.T) {
 	}
 
 	testMetrics := func(expectedOutput string) error {
-		resp, err := http.DefaultClient.Get(metricsEndpoint)
+		req, err := http.NewRequestWithContext(ctx, http.MethodGet, metricsEndpoint, nil)
+		if err != nil {
+			return err
+		}
+		resp, err := http.DefaultClient.Do(req)
 		if err != nil {
 			return err
 		}
-Original file line number
+Diff line change
@@ Expand Up / @@ -8,7 +8,6 @@ issues: @@
             - exhaustive
             - nilerr
             - interfacebloat
-            - noctx
             - nilnil
             - nakedret
             - musttag
@@ Expand Down @@