Skip to content

Latest commit

 

History

History

issues

Folders and files

NameName
Last commit message
Last commit date

parent directory

..
expected
expected
 
 
expected_subperils
expected_subperils
 
 
units
units
 
 
README.md
README.md
 
 
account.csv
account.csv
 
 
location.csv
location.csv
 
 
ri_info.csv
ri_info.csv
 
 
ri_scope.csv
ri_scope.csv
 
 

README.md

README

Process for adding a new issue to fm validation test

Creating and testing the new test case*

  1. Create unit test case folder oasislmf/validation/issues/units/[issue_number]
  2. Use the OED file templates account_new.csv (etc) in oasislmf/validation/issues/units and enter test case input data. Save in new unit folder
  3. Run new test case against fixed branch and generate correct results with loc_summary file; oasislmf exposure run -s validation/issues/units/[issue_number] -r validation/issues/units/[issue_number]/runs -o loc -f validation/issues/units/[issue_number]/runs/loc_summary.csv

Add the finished test case to the automated tests/fm

  1. In oasislmf/validation/issues/units edit units.txt and add new issue number to the bottom.
  2. In oasislmf/validation run combine.py as follows; python combine.py -d issues This will recombine the location and accounts file from all of the unit subfolders specified in units.txt and place them in the issues/ directory as location_concat.csv and account_concat.csv. Note that ri_info and ri_scope must be concatenated manually.
  3. Rename location_concat.csv as location.csv and account_concat.csv as account.csv
  4. Test the combined test files; oasislmf exposure run -s validation/issues/ -r validation/issues/runs -o loc -f validation/issues/runs/loc_summary.csv
  5. Compare with issues/expected and check that they are the same except the new issue results are present and correct in the combined results.
  6. Go into oasislmf/tests/fm and run pytest
  7. Either manually update the expected results in validation/issues to include the results for the new test case, or change the self.update_expected flag to True and rerun the pytest until all tests pass.

Notes on entering data for test cases

  • Enter the test case number in PortNumber fields, or alternatively prefix the PortNumber with the issue number. This is to make it unique across test cases.
  • Always use PortNumber in ri_scope file (if there is reinsurance). This is to ensure reinsurance does not get applied across test cases.
  • Reinsurance data must be added to the ri_info.csv and ri_scope in issues/ and reinsurance for the combined test cases are contained in this one set of files.
  • ReinsNumber must not overlap across test cases. Therefore when adding a new test case with reinsurance, the ReinsNumber must be incremented based on the last used ReinsNumber.