Add logging for oppia#6702, oppia#6604 (oppia#6833)

* add logging for guppy error, and filter expression error * fix lint * fix merge and review comments
saketringsia · Jun 15, 2019 · 9658729 · 9658729
1 parent 3069fe6
commit 9658729
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/core/templates/dev/head/filters/remove-duplicates-in-array.filter.ts b/core/templates/dev/head/filters/remove-duplicates-in-array.filter.ts
@@ -18,6 +18,10 @@
 
 oppia.filter('removeDuplicatesInArray', [function() {
   return function(input) {
+    if (!input.filter) {
+      throw Error(
+        'Bad input for removeDuplicatesInArray: ' + JSON.stringify(input));
+    }
     return input.filter(function(val, pos) {
       return input.indexOf(val) === pos;
     });

diff --git a/extensions/interactions/MathExpressionInput/directives/MathExpressionInputRulesService.ts b/extensions/interactions/MathExpressionInput/directives/MathExpressionInputRulesService.ts
@@ -19,6 +19,22 @@
 oppia.factory('MathExpressionInputRulesService', [function() {
   return {
     IsMathematicallyEquivalentTo: function(answer, inputs) {
+      try {
+        MathExpression.fromLatex(answer.latex);
+      } catch (e) {
+        throw Error(
+          'Bad expression in answer.latex: ' + e.message() + ' inputs: ' +
+          JSON.stringify(answer));
+      }
+
+      try {
+        MathExpression.fromLatex(inputs.x);
+      } catch (e) {
+        throw Error(
+          'Bad expression in inputs.x: ' + e.message() + ' inputs: ' +
+          JSON.stringify(inputs));
+      }
+
       return (
         MathExpression.fromLatex(answer.latex).equals(
           MathExpression.fromLatex(inputs.x)));