From 18724919dd7ec2cd6a6301e85fdef62540b54362 Mon Sep 17 00:00:00 2001 From: Nisheal John Date: Tue, 23 Jul 2019 06:52:43 +0530 Subject: [PATCH] Upgrade AngularJS Material to v1.1.19 (#7097) * bower based A.js Library upgrade * updates to app.yaml * Removed md-tab from class for static pages * Revert FAM from app.yaml * Update font css * Update version * Add Css * Use * Revert use * Revert Changes * Add version again * Rename manifest.json to 1.1.1 * Update 1.1.1 * Updates to 1.1.19 * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Add manifest * Update css * Test-2 * Fix e2e * Delete 1.1.1 * Revert Package-lock * Fix-2 * Add button click * Fix lint * Fix lint-2 * Fix mistakes * Fix css * Upgrade * Revert Package-lock.json * Reslove comments-1 * Fix CSS Stylings * Reslove comments-2 * Update README.md * Testing updates * Update comments * Fix lint * Revert perm * Fix issues with profile * Resolve comments * Fix extra space * Fix space-2 * Address comments-1 * Fix mistakes * Fix code-style * Fix code-style -2 * Fix code-style -3 * Fix code-style -4 * fix html-lint * Fix modal texts * Address comments-3 * space of hint & sol * Address comments 4 * Resolve comments * Address comments-2 * Check styles * Add lines * Add lines 2 * Revert "Resolve comments" This reverts commit bd741be4f923ffe04cf566f6eb54bce77e3890e3. * Revert "Address comments-2" This reverts commit 1afb71bff6e240f2322bf7023e9dd7bf8ccbe3c0. * Address comments * Add class to admin page * Code-style * Codestyle-2 * Resolve comments * Fix -3 * Fix line-height * Add new line --- .../hint-and-solution-buttons.directive.html | 3 + core/templates/dev/head/css/oppia.css | 95 +++- .../about-page/about-page.directive.html | 2 +- .../misc-tab/admin-misc-tab.directive.html | 13 +- .../creator-dashboard-page.directive.html | 13 +- ...create-feedback-thread-modal.template.html | 14 +- .../post-publish-modal.template.html | 1 + .../state-translation.directive.html | 2 +- .../audio-bar.directive.html | 2 +- .../exploration-footer.directive.html | 5 +- .../progress-nav.directive.html | 5 + .../flag-exploration-modal.template.html | 8 + .../information-card-modal.directive.html | 7 +- .../templates/take-break-modal.template.html | 6 + .../learner-dashboard-page.directive.html | 20 +- .../profile-page/profile-page.directive.html | 58 +- .../profile-page/profile-page.mainpage.html | 499 +++++++++--------- .../teach-page/teach-page.directive.html | 2 +- .../subtopics-list-tab.directive.html | 3 + .../new-topic-name-editor.template.html | 3 + .../interactions/NumericInput/protractor.js | 3 +- .../interactions/TextInput/protractor.js | 3 +- manifest.json | 7 +- 23 files changed, 468 insertions(+), 306 deletions(-) diff --git a/core/templates/dev/head/components/button-directives/hint-and-solution-buttons.directive.html b/core/templates/dev/head/components/button-directives/hint-and-solution-buttons.directive.html index 96d2b1a92378..39412c149550 100644 --- a/core/templates/dev/head/components/button-directives/hint-and-solution-buttons.directive.html +++ b/core/templates/dev/head/components/button-directives/hint-and-solution-buttons.directive.html @@ -70,7 +70,10 @@ .md-button.md-default-theme.oppia-learner-hint-solution-button { border-radius: 50%; height: 32px; + line-height: 32px; margin-top: 5px; + min-height: 32px; + min-width: 22px; padding: inherit; width: 32px; } diff --git a/core/templates/dev/head/css/oppia.css b/core/templates/dev/head/css/oppia.css index 71dafd5d77b5..53e96800310d 100644 --- a/core/templates/dev/head/css/oppia.css +++ b/core/templates/dev/head/css/oppia.css @@ -78,6 +78,14 @@ } /* Angular material overrides. */ +.list-inline > li { + width: 45px; +} + +.modal-body input { + height: 35px; +} + md-input-group.long > input { width: 100%; height: 45px; @@ -89,10 +97,51 @@ md-input-group.md-default-theme label { margin-bottom: 0; } +.md-button { + font-size: 16px; + line-height: 22px; + min-height: 22px; + min-width: 22px; + padding: 6px; +} + +.md-button.md-default.theme { + border-radius: 3px; +} + .md-button-success { color: #009688; } +.md-shadow-bottom-z-1, .md-button.md-raised:not([disabled]), +.md-button.md-fab { + box-shadow: 0 2px 5px 0 rgba(0,0,0,0.26); +} + +.md-button.md-default-theme.md-raised:not([disabled]):hover, +.md-button.md-raised:not([disabled]):hover { + background-color: rgba(158,158,158,0.3); + box-shadow: 0 4px 8px 0 rgba(0,0,0,0.4); + transform: translate3d(0,-1px,0); +} + +.oppia-learner-confirm-button.protractor-test-submit-answer-button.md-button[disabled] { + background-color: transparent; + color: rgba(0,0,0,0.38); + cursor: default; +} + +.oppia-learner-confirm-button.protractor-test-submit-answer-button.md-button[disabled]:hover { + background-color: #115fd4; + text-decoration: none; +} + +.oppia-learner-confirm-button.protractor-test-submit-answer-button.md-button { + font: 16px; + margin: 0; + min-width: 55px; +} + .md-button.oppia-learner-confirm-button, .md-button.oppia-learner-got-it-button, .md-button.oppia-learner-hint-solution-button { @@ -135,6 +184,7 @@ md-input-group.md-default-theme label { /* Attributes for material-icons. */ .material-icons { + line-height: 1; vertical-align: middle; } .material-icons.md-18 { @@ -280,13 +330,23 @@ body { } } -h1, h2 { +h1 { color: #000; + font-size: 2em; +} + +h2 { + color: #000; + font-size: 1.5em; + margin: .83em 0; } h3 { color: #222; + font-size: 1.17em; + font-weight: bold; line-height: 1.1; + margin-bottom: 18px; } a { @@ -459,6 +519,10 @@ textarea { opacity: 1.0; text-decoration: none; } +.oppia-feedback-card .btn-success { + margin-top: 19px; +} + @media (max-width: 1100px) { .oppia-site-feedback span { display: none; @@ -631,7 +695,9 @@ textarea { */ .oppia-footer-container h4 { + font-size: 1em; font-weight: bold; + margin: 1.33em 0; text-transform: uppercase; } @@ -1108,6 +1174,10 @@ textarea { .oppia-dashboard-aggregated-stats md-card { background: #fff; margin: 0 7.5px 70px 7.5px; + padding: 8px; +} +.stats-card h1 { + margin-bottom: 24px; } .oppia-dashboard-aggregated-stats .stats-card { @@ -1141,7 +1211,7 @@ span.sort-explorations-select .sort-order { } span.sort-explorations-select .sort-by-text { - margin: 8px 8px 0 ; + margin: 8px 8px 0; } span.sort-explorations-select .sort-options { @@ -1471,6 +1541,14 @@ md-card.oppia-dashboard-tile { width: 24px; } +.pop-over-text p { + line-height: 1.846; +} + +.popover p { + line-height: 1.846; +} + pre.oppia-pre-wrapped-text { white-space: pre-wrap; } @@ -1511,6 +1589,7 @@ pre.oppia-pre-wrapped-text { margin: 1.5em 0; } .oppia-static-content p { + line-height: 1.84; margin: 1.5em 0; } @@ -1546,6 +1625,9 @@ pre.oppia-pre-wrapped-text { margin-top: 10px; } +.popover-content .md-button, .md-button[disabled] { + font-size: 13px; +} /* The eight rules below should be in sync. */ .oppia-rte-editor > p:first-child { margin-top: 0; @@ -2423,6 +2505,7 @@ div#ng-curtain { /* Styles for the feedback popover component in the learner view. */ .oppia-feedback-popover-submit-btn-enabled { color: #009688; + font-size: 13px; } .oppia-rte-toolbar-image { @@ -2490,6 +2573,10 @@ div#ng-curtain { padding-left: 15px; } +.oppia-profile-container md-card.md-default-theme { + background-color: transparent; +} + md-card.preview-conversation-skin-inline-interaction { background-color: #f6f6f6; border-bottom-left-radius: 2px; @@ -2669,6 +2756,7 @@ md-card.preview-conversation-skin-supplemental-card { .oppia-info-card-content .card-metrics li .far { font-size: 24px; margin-right: 5px; + vertical-align: middle; } .oppia-info-card-bottom-row ul li a img { height: 20px; @@ -3038,6 +3126,7 @@ md-card.preview-conversation-skin-supplemental-card { .oppia-activity-summary-tile { background-color: #fff; + box-shadow: 0 2px 5px 0 rgba(0,0,0,0.26); cursor: pointer; display: inline-block; height: inherit; @@ -3360,8 +3449,8 @@ md-card.preview-conversation-skin-supplemental-card { .oppia-activity-summary-tile .metrics, .oppia-activity-summary-tile-mobile .metrics { - height: 30px; margin: 5px 12px 0; + min-height: 30px; padding: 0; } diff --git a/core/templates/dev/head/pages/about-page/about-page.directive.html b/core/templates/dev/head/pages/about-page/about-page.directive.html index 7a92d46f5299..343bf9bee47d 100644 --- a/core/templates/dev/head/pages/about-page/about-page.directive.html +++ b/core/templates/dev/head/pages/about-page/about-page.directive.html @@ -5,7 +5,7 @@

-
+
  • diff --git a/core/templates/dev/head/pages/admin-page/misc-tab/admin-misc-tab.directive.html b/core/templates/dev/head/pages/admin-page/misc-tab/admin-misc-tab.directive.html index 1de009193647..b2dcc568d8c5 100644 --- a/core/templates/dev/head/pages/admin-page/misc-tab/admin-misc-tab.directive.html +++ b/core/templates/dev/head/pages/admin-page/misc-tab/admin-misc-tab.directive.html @@ -9,12 +9,12 @@

    Topic Similarities

- +

Search Index

- +

Extract Data

@@ -34,3 +34,12 @@

Extract Data

Status: <[$ctrl.dataExtractionQueryStatusMessage]>

+ + diff --git a/core/templates/dev/head/pages/creator-dashboard-page/creator-dashboard-page.directive.html b/core/templates/dev/head/pages/creator-dashboard-page/creator-dashboard-page.directive.html index 5b3ab6e0a04d..2fb064344ef3 100644 --- a/core/templates/dev/head/pages/creator-dashboard-page/creator-dashboard-page.directive.html +++ b/core/templates/dev/head/pages/creator-dashboard-page/creator-dashboard-page.directive.html @@ -135,9 +135,9 @@

< ng-change="$ctrl.setExplorationsSortingOptions($ctrl.currentSortType)" ng-options="$ctrl.EXPLORATIONS_SORT_BY_KEYS[key] as value | translate for (key, value) in $ctrl.HUMAN_READABLE_EXPLORATIONS_SORT_BY_KEYS"> - + ng-class="$ctrl.isCurrentSortDescending ? 'fa-long-arrow-alt-up': 'fa-long-arrow-alt-down'">

@@ -163,7 +163,7 @@

<

- @@ -277,7 +277,7 @@

  • - @@ -326,9 +326,9 @@

    ng-options="$ctrl.SUBSCRIPTION_SORT_BY_KEYS[key] as value for (key, value) in $ctrl.HUMAN_READABLE_SUBSCRIPTION_SORT_BY_KEYS" style="width: 160px;"> - + ng-class="$ctrl.isCurrentSubscriptionSortDescending ? 'fa-long-arrow-alt-up': 'fa-long-arrow-alt-down'">

  • @@ -641,6 +641,7 @@

    Suggestions to review

    .oppia-dashboard-intro-card p { margin-bottom: 12px; + line-height: 1.84em; } .oppia-dashboard-table .oppia-dashboard-table-headings p { diff --git a/core/templates/dev/head/pages/exploration-editor-page/feedback-tab/templates/create-feedback-thread-modal.template.html b/core/templates/dev/head/pages/exploration-editor-page/feedback-tab/templates/create-feedback-thread-modal.template.html index 742a622802ad..4f36b9a5baf1 100644 --- a/core/templates/dev/head/pages/exploration-editor-page/feedback-tab/templates/create-feedback-thread-modal.template.html +++ b/core/templates/dev/head/pages/exploration-editor-page/feedback-tab/templates/create-feedback-thread-modal.template.html @@ -3,11 +3,21 @@

    Start New Feedback Thread

    + + diff --git a/core/templates/dev/head/pages/exploration-editor-page/modal-templates/post-publish-modal.template.html b/core/templates/dev/head/pages/exploration-editor-page/modal-templates/post-publish-modal.template.html index 43508c08527e..c89ea07f5ba6 100644 --- a/core/templates/dev/head/pages/exploration-editor-page/modal-templates/post-publish-modal.template.html +++ b/core/templates/dev/head/pages/exploration-editor-page/modal-templates/post-publish-modal.template.html @@ -38,6 +38,7 @@ .oppia-share-publish-body .oppia-share-publish-link{ display: inline-grid; + width: 100%; } .oppia-share-publish-body .oppia-share-publish-link div { diff --git a/core/templates/dev/head/pages/exploration-editor-page/translation-tab/state-translation/state-translation.directive.html b/core/templates/dev/head/pages/exploration-editor-page/translation-tab/state-translation/state-translation.directive.html index de8a1e64c609..2ab77ad86af5 100644 --- a/core/templates/dev/head/pages/exploration-editor-page/translation-tab/state-translation/state-translation.directive.html +++ b/core/templates/dev/head/pages/exploration-editor-page/translation-tab/state-translation/state-translation.directive.html @@ -2,7 +2,7 @@ <[stateName]>
    -
    +
    + + diff --git a/core/templates/dev/head/pages/exploration-player-page/templates/information-card-modal.directive.html b/core/templates/dev/head/pages/exploration-player-page/templates/information-card-modal.directive.html index 8d3166486b44..9bee25109eaf 100644 --- a/core/templates/dev/head/pages/exploration-player-page/templates/information-card-modal.directive.html +++ b/core/templates/dev/head/pages/exploration-player-page/templates/information-card-modal.directive.html @@ -65,7 +65,7 @@

    <[explorationTitle]>

    <['I18N_PLAYER_TAGS_TOOLTIP' | translate]>
    - +
    <[explorationTitle]> explorationTags.tagsInTooltip.length === 0"> - +
    @@ -101,4 +101,7 @@

    <[explorationTitle]>

    .oppia-info-card-content .private-card-info { color: red; } + .oppia-info-card-bottom-row em { + font-size: 12px; + } diff --git a/core/templates/dev/head/pages/exploration-player-page/templates/take-break-modal.template.html b/core/templates/dev/head/pages/exploration-player-page/templates/take-break-modal.template.html index 6043b9ed1fc7..50fe3898f423 100644 --- a/core/templates/dev/head/pages/exploration-player-page/templates/take-break-modal.template.html +++ b/core/templates/dev/head/pages/exploration-player-page/templates/take-break-modal.template.html @@ -17,3 +17,9 @@

    + + diff --git a/core/templates/dev/head/pages/learner-dashboard-page/learner-dashboard-page.directive.html b/core/templates/dev/head/pages/learner-dashboard-page/learner-dashboard-page.directive.html index 6ebf570d63f1..dd73899b37ab 100644 --- a/core/templates/dev/head/pages/learner-dashboard-page/learner-dashboard-page.directive.html +++ b/core/templates/dev/head/pages/learner-dashboard-page/learner-dashboard-page.directive.html @@ -162,9 +162,9 @@

    <[$ctrl.subscriptionsList.length]>

    ng-change="$ctrl.setExplorationsSortingOptions($ctrl.currentExpSortType)" ng-options="value['key'] as value['i18nId'] | translate for (key, value) in $ctrl.EXPLORATIONS_SORT_BY_KEYS_AND_I18N_IDS"> - + ng-class="$ctrl.isCurrentExpSortDescending ? 'fa-long-arrow-alt-down':'fa-long-arrow-alt-up'"> @@ -179,9 +179,9 @@

    <[$ctrl.subscriptionsList.length]>

    ng-options="value['key'] as value['i18nId'] | translate for (key, value) in $ctrl.SUBSCRIPTION_SORT_BY_KEYS_AND_I18N_IDS" style="width: 160px;"> - + ng-class="$ctrl.isCurrentSubscriptionSortDescending ? 'fa-long-arrow-alt-down':'fa-long-arrow-alt-up'"> @@ -196,9 +196,9 @@

    <[$ctrl.subscriptionsList.length]>

    ng-options="value['key'] as value['i18nId']| translate for (key, value) in $ctrl.FEEDBACK_THREADS_SORT_BY_KEYS_AND_I18N_IDS" style="width: 160px;"> - + ng-class="$ctrl.isCurrentFeedbackSortDescending ? 'fa-long-arrow-alt-down':'fa-long-arrow-alt-up'">
    @@ -231,7 +231,7 @@

    <[$ctrl.subscriptionsList.length]>

    -