Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect invalid exprs in parser used by pretty-printer tests #134599

Merged
merged 4 commits into from
Dec 22, 2024
Merged

Detect invalid exprs in parser used by pretty-printer tests #134599

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3f98f76
Check that pretty-printer parenthesis test operates on the whole test…
dtolnay Dec 21, 2024
65ba6ac
Extract ui-fulldeps expression parser into module
dtolnay Dec 21, 2024
822e806
Switch pretty-printer roundtrip test to better parser
dtolnay Dec 21, 2024
1f2028f
Show which test case was found to be meaningless
dtolnay Dec 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Show which test case was found to be meaningless
  • Loading branch information
@dtolnay
dtolnay committed Dec 22, 2024
commit 1f2028f93013df476888b34fad78944ae9e4e837
4 changes: 3 additions & 1 deletion tests/ui-fulldeps/pprust-parenthesis-insertion.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,9 @@ fn main() -> ExitCode {
let psess = &ParseSess::new(vec![rustc_parse::DEFAULT_LOCALE_RESOURCE]);

for &source_code in EXPRS {
let expr = parse_expr(psess, source_code).unwrap();
let Some(expr) = parse_expr(psess, source_code) else {
panic!("Failed to parse original test case: {source_code}");
};

// Check for FALSE POSITIVE: pretty-printer inserting parentheses where not needed.
// Pseudocode:
Expand Down
Loading