Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle member constraints directly in the mir type checker #134501

Merged
merged 2 commits into from
Dec 21, 2024
Merged

handle member constraints directly in the mir type checker #134501

merged 2 commits into from
Dec 21, 2024

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Dec 19, 2024

cleaner, faster, easier to change going forward :> fixes #109654

r? @oli-obk @compiler-errors

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Dec 19, 2024
@rustbot
Copy link
Collaborator

rustbot commented Dec 19, 2024

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

@lcnr
Copy link
Contributor Author

lcnr commented Dec 19, 2024

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 19, 2024
@lcnr lcnr closed this Dec 19, 2024
@lcnr lcnr reopened this Dec 19, 2024
@lcnr
Copy link
Contributor Author

lcnr commented Dec 19, 2024

@bors try

@lcnr
Copy link
Contributor Author

lcnr commented Dec 19, 2024

@bors ping

@bors
Copy link
Contributor

bors commented Dec 19, 2024

😪 I'm awake I'm awake

@lqd
Copy link
Member

lqd commented Dec 19, 2024

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 19, 2024
@bors
Auto merge of rust-lang#134501 - lcnr:member-constraints-yeet, r=<try>
9cb51e9 
handle member constraints directly in the mir type checker

cleaner, faster, easier to change going forward :> fixes rust-lang#109654

r? `@oli-obk` `@compiler-errors`
@bors
Copy link
Contributor

bors commented Dec 19, 2024

⌛ Trying commit 7f07ce0 with merge 9cb51e9...

@bors
Copy link
Contributor

bors commented Dec 19, 2024

☀️ Try build successful - checks-actions
Build commit: 9cb51e9 (9cb51e9be7e1718708b68f18976b181058226ad5)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (9cb51e9): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.3% [-0.6%, -0.2%] 62
Improvements ✅
(secondary)		 -0.3% [-0.4%, -0.1%] 43
All ❌✅ (primary) -0.3% [-0.6%, -0.2%] 62

Max RSS (memory usage)

Results (primary -0.6%, secondary -0.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 2.7% [2.7%, 2.7%] 1
Regressions ❌
(secondary)		 3.5% [3.5%, 3.5%] 1
Improvements ✅
(primary)		 -1.7% [-3.6%, -0.6%] 3
Improvements ✅
(secondary)		 -2.6% [-3.2%, -2.1%] 2
All ❌✅ (primary) -0.6% [-3.6%, 2.7%] 4

Cycles

Results (secondary 4.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 4.1% [2.4%, 5.3%] 4
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 767.394s -> 767.478s (0.01%)
Artifact size: 330.38 MiB -> 330.26 MiB (-0.04%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 20, 2024
@lcnr lcnr force-pushed the member-constraints-yeet branch from 7f07ce0 to 67cd9e6 Compare December 20, 2024 08:31
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@lcnr lcnr force-pushed the member-constraints-yeet branch from 67cd9e6 to 9792cf0 Compare December 20, 2024 09:04
@oli-obk
Copy link
Contributor

oli-obk commented Dec 20, 2024

r=me with CI happy

@lcnr
Copy link
Contributor Author

lcnr commented Dec 20, 2024

@bors r=oli-obk

@bors
Copy link
Contributor

bors commented Dec 20, 2024

📌 Commit 9792cf0 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 20, 2024
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Dec 20, 2024
@bors
Copy link
Contributor

bors commented Dec 21, 2024

⌛ Testing commit 9792cf0 with merge 9bd5f33...

@bors
Copy link
Contributor

bors commented Dec 21, 2024

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 9bd5f33 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 21, 2024
@bors bors merged commit 9bd5f33 into rust-lang:master Dec 21, 2024
7 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Dec 21, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (9bd5f33): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.4% [-0.5%, -0.2%] 65
Improvements ✅
(secondary)		 -0.3% [-0.6%, -0.0%] 58
All ❌✅ (primary) -0.4% [-0.5%, -0.2%] 65

Max RSS (memory usage)

Results (primary -0.2%, secondary -0.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 3.5% [3.5%, 3.5%] 1
Regressions ❌
(secondary)		 2.4% [2.4%, 2.4%] 1
Improvements ✅
(primary)		 -1.1% [-2.1%, -0.4%] 4
Improvements ✅
(secondary)		 -3.0% [-3.0%, -3.0%] 1
All ❌✅ (primary) -0.2% [-2.1%, 3.5%] 5

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 766.218s -> 765.578s (-0.08%)
Artifact size: 330.18 MiB -> 330.14 MiB (-0.01%)

@lcnr lcnr deleted the member-constraints-yeet branch December 23, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk approved these changes

Assignees

@oli-obk oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Milestone
1.85.0
Development

Successfully merging this pull request may close these issues.

member constraints leak through InferCtxt snapshots
7 participants
@lcnr @rustbot @rust-timer @bors @lqd @rust-log-analyzer @oli-obk