Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate shell completions for x as well #134405

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Generate shell completions for x as well #134405

merged 1 commit into from
Dec 23, 2024
+5,952 −2

Conversation

rmehri01
Copy link
Contributor

@rmehri01 rmehri01 commented Dec 17, 2024 •
edited
Loading

It would be nice to be have shell completions for both ./x and x (installed with cargo install --path src/tools/x) instead of just x.py. This pr generates the corresponding completions for each shell in a similar way to x.py but under x.<shell> instead.

@rustbot
Copy link
Collaborator

rustbot commented Dec 17, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Dec 17, 2024
@rustbot
Copy link
Collaborator

rustbot commented Dec 17, 2024

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

@jyn514
Copy link
Member

jyn514 commented Dec 17, 2024

I tested on bash, zsh, and fish and it seems to work but I don't have a windows machine to test powershell

powershell runs on linux, you can install it with apt or dnf

@rmehri01
Copy link
Contributor Author

I tested on bash, zsh, and fish and it seems to work but I don't have a windows machine to test powershell

powershell runs on linux, you can install it with apt or dnf

Oh cool, thanks! Yeah seems like this doesn't actually work in powershell because the using statements have to be at the top

onur-ozkan
onur-ozkan approved these changes Dec 23, 2024
View reviewed changes
Copy link
Member

@onur-ozkan onur-ozkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@onur-ozkan
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Dec 23, 2024

📌 Commit bc1737b has been approved by onur-ozkan

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 23, 2024
@bors
Copy link
Contributor

bors commented Dec 23, 2024

⌛ Testing commit bc1737b with merge bdc6b3d...

@bors
Copy link
Contributor

bors commented Dec 23, 2024

☀️ Test successful - checks-actions
Approved by: onur-ozkan
Pushing bdc6b3d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 23, 2024
@bors bors merged commit bdc6b3d into rust-lang:master Dec 23, 2024
7 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Dec 23, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (bdc6b3d): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.4% [0.4%, 0.4%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -0.8%, secondary 3.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 3.6% [3.6%, 3.6%] 1
Improvements ✅
(primary)		 -0.8% [-0.8%, -0.8%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.8% [-0.8%, -0.8%] 1

Cycles

Results (secondary 3.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 3.0% [3.0%, 3.0%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 764.878s -> 763.421s (-0.19%)
Artifact size: 330.56 MiB -> 330.54 MiB (-0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onur-ozkan onur-ozkan onur-ozkan approved these changes

Assignees

@onur-ozkan onur-ozkan

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.85.0
Development

Successfully merging this pull request may close these issues.
7 participants
@rmehri01 @rustbot @jyn514 @onur-ozkan @bors @rust-timer @Mark-Simulacrum