Audit run-fail
ui tests to see if they need *exact* run stderr/stdoutΒ #134889
Open
Description
opened on Dec 29, 2024
compiletest triage: I'm not convinced switching
error-pattern
run-fail ui tests to use only the current form ofcheck-run-results
is an improvement overerror-pattern
unconditionally. If anything, it would be a regression to flaky tests in many cases that are sensitive to exact run stdout/stderr (line numbers, backtraces that can depend on platform-specific unwind mechanism, concrete addresses, version numbers, etc.).I would be in favor of auditing some of these run-fail tests and sparingly add
check-run-results
if the exact run stderr/stdout is critical for the intention of the test, but not in a blanket fashion. As such, I'm going to close this issue in favor of a more concrete audit issue.
Metadata
Assignees
Labels
Area: The testsuite used to check the correctness of rustcCategory: PRs that clean code up or issues documenting cleanup.Call for participation: Medium difficulty. Experience needed to fix: Intermediate.Call for participation: An issue involves lots of work and is better handled as many small tasks.Relevant to the compiler team, which will review and decide on the PR/issue.
Activity