Skip to content

Target feature implications for negative features are handled inconsistently between codegen and cfg(target_feature) #134792

Open
@RalfJung

Description

The logic that computes cfg(target_feature) takes into account target feature implications when handling something like -sse: it will also remove avx from the list of enabled target features in that case. However, the logic that computes which flags we set for codegen (which, unfortunately, is completely separate), does not do the same: it will add -sse to LLVM's target feature list, but does not do anything about Rust-level target feature implications.

This can't be correct -- either negative target features also imply that their "reverse dependencies" get disabled, or they do not. We shouldn't do one thing in codegen and a different thing for cfg. Or is there some good reason for this?

The logic for this was added in #128221.

Cc @calebzulawski @Amanieu @workingjubilee

Metadata

Assignees

No one assigned

    Labels

    A-target-featureArea: Enabling/disabling target features like AVX, Neon, etc.C-bugCategory: This is a bug.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions