replace NULL value (empty list) by NA #200
Conversation
|
The main challenge with this approach is that this breaks nested lists: I think in the best case scenario, you wouldn't have NULLs inside list columns in the first place; I'm hoping to find time to look at your context in the issue to see if httr can be used to get out of this situation, so you don't wind up with such a weird tibble (I've never seen a NULL inside a list column in a tibble before! I can only make a standard data.frame do that via list2DF). Failing that, I think we might be able to spot-convert NULL items in lists to NA items instead (at least for list elements which aren't themselves lists). tl;dr I'm worried about fixing NULLs inside of list columns specifically, rather than thinking about how we handle list columns more holistically. (edit to add: None of the revdeps appear to test using nested lists here:
|
I don't understand, it's supposed to work ? I got the same error with the last version (commit 321c679) |
|
With the current version of geojsonio: > tibble::tibble(x = c(list(NULL), 1, list(c("a", "b"))), latitude = 42, longitude = 76) |>
+ geojsonio::geojson_list() |>
+ geojsonio::geojson_sf()
Registered S3 method overwritten by 'geojsonsf':
method from
print.geojson geojson
Assuming 'longitude' and 'latitude' are longitude and latitude, respectively
Simple feature collection with 3 features and 1 field
Geometry type: POINT
Dimension: XY
Bounding box: xmin: 76 ymin: 42 xmax: 76 ymax: 42
Geodetic CRS: WGS 84
x geometry
1 { } POINT (76 42)
2 1 POINT (76 42)
3 [ "a", "b" ] POINT (76 42) |
|
That's strange. I have reinstalled the package and I got almost the same error. library(dplyr)
#>
#> Attaching package: 'dplyr'
#> The following objects are masked from 'package:stats':
#>
#> filter, lag
#> The following objects are masked from 'package:base':
#>
#> intersect, setdiff, setequal, union
tibble::tibble(x = c(list(NULL), 1, list(c("a", "b"))), latitude = 42, longitude = 76) |>
geojsonio::geojson_list() |>
geojsonio::geojson_sf()
#> Registered S3 method overwritten by 'geojsonsf':
#> method from
#> print.geojson geojson
#> Assuming 'longitude' and 'latitude' are longitude and latitude, respectively
#> Error in `[[<-.data.frame`(`*tmp*`, nm.lc[i], value = list("{ }", "1", : replacement has 3 rows, data has 0
packageVersion("geojsonio")
#> [1] '0.11.0.9000'
packageVersion("jsonlite")
#> [1] '1.8.4'
packageVersion("sf")
#> [1] '1.0.12' |
issue #199