Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing support for single quote strings #25

Open
ReinhardHahn opened this issue Sep 10, 2021 · 0 comments
Open

Missing support for single quote strings #25

ReinhardHahn opened this issue Sep 10, 2021 · 0 comments

Comments

@ReinhardHahn
Copy link
Contributor

ReinhardHahn commented Sep 10, 2021

In magik-mode and magik-session mode in the follwoing expression the string argument isn't recognised correctly:

write('a single quote delimted string')

In fact the main reason to use single quotes is that you want to include double quotes (") within your string constant. If you have an uneven number oft the double quotes in the consequence is even worse. In the following expression

write('a single quote delimited string including a double quote (") character')

EMACS reconises a string constant starting with the " character, which never ends. So to get a correct syntax colouring (and in magik-mode to get a correct indentation, as well) you might add a #") at the end of the line as workaround.

Possible solution

A solution is implemented in PR #22 which has been reverted with PR #23 due to issue #24 and "some display issues within the method finder/class browser", which are not specified in detail

Rating Discussion

Solution makes Issue #24 more serious

It is correct, that the solution of PR #22 increases the impact of issue #24

But if that's the only problem with the solutions #22, I regard it anyway, as a good idea, to reactivate it, for three reasons:

  • Both issues concern syntax colouring, but this issue concerns indentation as well, which makes this issue more serious
  • The increased impact of other issue is just a quantitive change but not a qualitative. It is better if we have to deal only with one issue with one workaround, but with two issues with two different workrounds.
  • The Increase of the impact of the other issue is to my opinion not that heavy, that it legitimates pushing back a valid solution for this issue.

magik-cb-mode issues?

@roadrunner1776 reported in #23 (comment):

Also, some display issues within the method finder/class browser

which he/she didn't specify in detail. I didn't see any (what does not mean, that the don't exist...). If these are real and heavy, I might change my mind...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant