Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] [spark] Set "HOST_IP" environmental variable for Ray worker nodes #49403

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

WeichenXu123
Copy link
Contributor

Why are these changes needed?

Set "HOST_IP" environmental variable for Ray worker nodes.

Some library such as vLLM uses HOST_IP environmental variables, but for some spark cluster configurations, it is not set correctly in spark worker side. This PR fix the issue.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
@WeichenXu123 WeichenXu123 changed the title [spark] Set "HOST_IP" environmental variable for Ray worker nodes [Draft] [spark] Set "HOST_IP" environmental variable for Ray worker nodes Dec 22, 2024
@jcotant1 jcotant1 added the core Issues that should be addressed in Ray Core label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues that should be addressed in Ray Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants