-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): table data TTL #5234
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluestreak01
commented
Dec 9, 2024
putInt() was used to write a boolean value
bluestreak01
commented
Jan 7, 2025
This reverts commit 850298a.
[PR Coverage check]😍 pass : 251 / 282 (89.01%) file detail
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New syntax:
Data whose TTL has expired will be deleted, at the granularity of full partitions.
A row's lifetime is measured as
max_timestamp - row_timestamp
, so it doesn't relate to wall clock time. Whether we do it this way or by wall clock time is something we can discuss further.TTL is persisted as either the number of hours (for the HOUR, DAY, WEEK units), or the number of months (for the MONTH and YEAR units). A positive value implies hours, negative implies months. Zero value means "unbounded TTL".
Using
PGWireInsertSelectBenchmark
shows no performance impact for the base case where no partitions need to be dropped. Raw perf data:TODO:
tables()
WalWriterFuzzTest
FUTURE WORK:
Make writing expired data a no-op. If it's behind TTL, it never gets written.