Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sql): BREAKING 💥 - align common column names across multiple catalogue views #5111

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

fix(sql): BREAKING 💥 - align common column names across multiple catalogue views #5111

wants to merge 6 commits into from

Conversation

bluestreak01
Copy link
Member

@bluestreak01 bluestreak01 commented Oct 28, 2024 •
edited
Loading

Affected views:

  • wal_tables
  • table_partitions()
  • SHOW PARTITIONS
  • table_storage

Details

wal_tables.name -> wal_tables.table_name
table_partitions.index -> table_partitions.partition_index
table_partitions.name -> table_partitions.partition_name
table_partitions.isparquet -> table_partitions.parquet
table_storage.tablename -> table_storage.table_name

New column:

table_partitions.partition_name_txn -> the numeric txn that is used in constructing partition directory name.

@nwoolmer nwoolmer mentioned this pull request Oct 29, 2024
Closed
@nwoolmer
Copy link
Contributor

We also have this open PR to adjust the confusing writeLagTxnCount name: #5001

@ideoma
Copy link
Collaborator

ideoma commented Oct 29, 2024

[PR Coverage check]

😍 pass : 39 / 41 (95.12%)

file detail

path covered line new line coverage
🔵 io/questdb/griffin/engine/table/ShowPartitionsRecordCursorFactory.java 27 29 93.10%
🔵 io/questdb/griffin/engine/table/TableStorageRecordCursorFactory.java 1 1 100.00%
🔵 io/questdb/griffin/engine/functions/catalogue/WalTablesFunctionFactory.java 11 11 100.00%

@bluestreak01 bluestreak01 added the SQL Issues or changes relating to SQL execution label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
SQL Issues or changes relating to SQL execution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bluestreak01 @nwoolmer @ideoma