bug: apply request_timeout to timeout_connect #72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ureq
has a potential bug in its agent builder code regarding timeouts. There are two kinds of timeout:agent_builder.timeout_connect()
applies to establishing the TCP connectionagent_builder.timeout()
applies to the overall HTTP requesttimeout_connect
is always applied for the connection phase, even if longer than the overall timeouttimeout_connect
has a default of 15 secondstimeout_connect
to unconfigured statetimeout
setting shorter thantimeout_connect
is basically ignoredThis PR applies a workaround and sets
timeout_connect
to QuestDB's parameterrequest_timeout
.This partially addresses questdb/py-questdb-client#75.
Also addresses #66.