add types.GenericAlias.__mro_entries__
#13284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
steam.py has a custom subclass of GenericAlias which defines a |
This comment has been minimized.
This comment has been minimized.
srittau
requested changes
Jan 13, 2025
Co-authored-by: Sebastian Rittau <srittau@rittau.biz>
|
Diff from mypy_primer, showing the effect of this PR on open source code: steam.py (https://github.com/Gobot1234/steam.py)
+ steam/trade.py:189: error: Argument 1 of "__mro_entries__" is incompatible with supertype "GenericAlias"; supertype defines the argument type as "Iterable[object]" [override]
+ steam/trade.py:189: note: This violates the Liskov substitution principle
+ steam/trade.py:189: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#incompatible-overrides
schemathesis (https://github.com/schemathesis/schemathesis)
- File "/tmp/mypy_primer/old_mypy/venv/bin/mypy", line 8, in <module>
+ File "/tmp/mypy_primer/new_mypy/venv/bin/mypy", line 8, in <module>
- File "/tmp/mypy_primer/old_mypy/venv/lib/python3.13/site-packages/mypy/__main__.py", line 15, in console_entry
+ File "/tmp/mypy_primer/new_mypy/venv/lib/python3.13/site-packages/mypy/__main__.py", line 15, in console_entry
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used
Iterable[object]because it matches the call signature ofresolve_bases, but it could just as easily beAnybecause the specific implementation here doesn't look at the argument and always returns a 1-tuple of the__origin__attribute.