Updated README.md and update boundary shapefile writer

pvelissariou1 · Jan 25, 2020 · 4a557ca · 4a557ca
1 parent 2e9b009
commit 4a557ca
Show file tree

Hide file tree

Showing 5 changed files with 50 additions and 7 deletions.
diff --git a/README.md b/README.md
@@ -40,3 +40,10 @@ from pyschism.mesh import Hgrid
 hgrid = Hgrid.open('hgrid.gr3')
 hgrid.make_plot(show=True)
 ```
+##### Example 2: Write boundaries to shapefile
+```python
+# open mesh as 
+from pyschism.mesh import Hgrid
+hgrid = Hgrid.open('hgrid.gr3')
+hgrid.write_boundaries("/path/to/output/dir", overwrite=True)
+```
diff --git a/pyschism/mesh/base.py b/pyschism/mesh/base.py
@@ -361,10 +361,6 @@ def geom_string(geom_type, geom):
             f += f"{-self.values[i]:<.16E}\n"
         return f
 
-    @property
-    def geom(self):
-        return self.pslg.geom
-
     @property
     @lru_cache
     def grd(self):

diff --git a/pyschism/mesh/gmesh.py b/pyschism/mesh/gmesh.py
@@ -61,8 +61,12 @@ def delete_boundary_data(self, ibtype, id):
 
     def write_boundaries(self, path, overwrite=False):
         path = pathlib.Path(path)
+        # print(path)
+        if path.exists() and not overwrite:
+            msg = "Destination path exists and overwrite=False"
+            raise IOError(msg)
         with fiona.open(
-                    path.name,
+                    path.absolute(),
                     'w',
                     driver='ESRI Shapefile',
                     crs=self.crs.srs,

diff --git a/tests/coverage.svg b/tests/coverage.svg
diff --git a/tests/mesh/test_gmesh.py b/tests/mesh/test_gmesh.py
@@ -250,5 +250,41 @@ def test_delete_boundary_data(self):
         msh.set_boundary_data(None, 0, data)
         msh.delete_boundary_data(None, 0)
 
+    def test_write_boundaries(self):
+        tmpdir = tempfile.TemporaryDirectory()
+        shp = pathlib.Path(tmpdir.name).absolute()
+        boundaries = {
+            None: {
+                0: {
+                    'indexes':
+                        [139510, 140443, 140461, 140462, 141993, 150761]
+                    }
+                }
+            }
+        msh = Gmesh(
+            self.coords,
+            self.triangles,
+            crs="EPSG:3395",
+            boundaries=boundaries)
+        msh.write_boundaries(shp, overwrite=True)
+
+    def test_write_boundaries_raises(self):
+        tmpdir = tempfile.TemporaryDirectory()
+        shp = pathlib.Path(tmpdir.name).absolute()
+        boundaries = {
+            None: {
+                0: {
+                    'indexes':
+                        [139510, 140443, 140461, 140462, 141993, 150761]
+                    }
+                }
+            }
+        msh = Gmesh(
+            self.coords,
+            self.triangles,
+            crs="EPSG:3395",
+            boundaries=boundaries)
+        self.assertRaises(IOError, msh.write_boundaries, shp)
+
 if __name__ == '__main__':
     unittest.main()