DriverConstants.h Question: es_output_device_t #21

ki6syd · 2024-03-26T08:02:09Z

ki6syd
Mar 26, 2024

I am bringing up a custom board based on ESP32-S3 and ES8388, and ran into confusing hardware behavior when enabling only one of the DACs inside the ES8388. The codec outputs a clean signal when I enable all DAC outputs, but I'm finding that the wrong output is disabled when I try to power down an output.

The definition of the es_output_device_t enum does not match what I would expect when reading the ES8388 datasheet. An example: DriverConstants.h defines _DAC_OUTPUT_LOUT1 = 0x04. From section 6.1.5 of the datasheet, I would expect 0x04 to correspond to ROUT2. Note that bits 0 and 1 are unused in this register.

This is the datasheet that I am using for ES8388.

Anyone able to explain where I'm going wrong in checking the datasheet against the enum definition? Thank you!

Max

P.S. - this is my first time posting a discussion on GitHub, any feedback on how to ask good questions is appreciated.

Answered by pschatzmann

Mar 26, 2024

I was just taking the code that was provided by the Espressif ADF framework.
As far as I can see, the es8388_config_output_device() method is not used anywhere in my framework and the devices are defined via es8388_init()

If you want to correct this method, I suggest that you add a switch/case logic to the es8388.c. I am always happy to get corrections via a pull request.

ps. how about getting rid of the enum completly and use int values instead of es_output_device or es_input_device ?

View full answer

pschatzmann · 2024-03-26T09:22:52Z

pschatzmann
Mar 26, 2024
Maintainer

I was just taking the code that was provided by the Espressif ADF framework.
As far as I can see, the es8388_config_output_device() method is not used anywhere in my framework and the devices are defined via es8388_init()

If you want to correct this method, I suggest that you add a switch/case logic to the es8388.c. I am always happy to get corrections via a pull request.

ps. how about getting rid of the enum completly and use int values instead of es_output_device or es_input_device ?

2 replies

ki6syd Mar 27, 2024
Author

Thank you for the quick reply!

That makes sense. I'll check for any evidence that others have found something similar in the Espressif ADF, and then test out a correction. I was disabling the output via es8388_init().

For the switch/case logic, do you mean this for both es8388_init() and es8388_config_output_device()? I can't say I understand the use case for es8388_config_output_device(), which looks like it can only enable a DAC. Avoiding the enum makes sense to me - there are already writes to ES8388_DACPOWER that aren't based on es_output_device.

ki6syd Mar 28, 2024
Author

@pschatzmann , following up on this one: I couldn't find anybody calling out an error in Espressif's code, but I did find this driver with different values that match the datasheet. I do think there is an error and es_output_device_t should be:

typedef enum {
    DAC_OUTPUT_MIN = -1,
    DAC_OUTPUT_LOUT1 = 0x20,
    DAC_OUTPUT_LOUT2 = 0x08,
    DAC_OUTPUT_SPK   = 0x09,
    DAC_OUTPUT_ROUT1 = 0x10,
    DAC_OUTPUT_ROUT2 = 0x04,
    DAC_OUTPUT_ALL = 0x3c,
    DAC_OUTPUT_MAX,
} es_dac_output_t;

Let me know if it'd be helpful for me to test the change on my hardware and submit a PR. Wasn't sure how you felt about diverging from Espressif's driver.

pschatzmann · 2024-03-27T01:57:39Z

pschatzmann
Mar 27, 2024
Maintainer

As far as i know es_output_device_t does not use es_output_device_t, so there shouldn't be anything to correct there.
What exactly is your use case that you want to implement ?

The idea of this library is to use the AudioBoard methods and not the low lever drivers

1 reply

ki6syd Mar 27, 2024
Author

I need to turn specific DACs on/off on-the-fly in my application. The hardware is a radio transceiver where a single ES8388 is sitting between the ESP32, headphones, mic, and audio in/out from multiple RF modulator/demodulators. I'm planning to turn one of the DACs off during radio RX mode, but was just doing the initial hardware bringup when I found the surprising behavior.

I love the library concept and am planning to work through the AudioBoard methods! I just ended up looking in the es8388 driver to debug this.

pschatzmann · 2024-03-27T09:11:46Z

pschatzmann
Mar 27, 2024
Maintainer

To support TDS is started to add the method setMute(bool, int line) to some Drivers
I added now a DRAFT implementation to the AudioDriverES8388Class as well

1 reply

ki6syd Mar 28, 2024
Author

Thanks, Phil. I pulled your changes and am doing something like audio_board.getDriver()->setMute(false, 0) to test.

I'm trying this without success and think maybe line 794/796 should be swapped? Looks like the call to setMute(false) is undoing line_active[line] = !mute right now.

pschatzmann · 2024-03-28T10:45:41Z

pschatzmann
Mar 28, 2024
Maintainer

I committed a correction. Now I using the right es_dac_output_t values and the output device with setMute(mute, line) is determined correctly as well.

But somehow I do not manage to mute the speaker on my AudioKit and I don't manage to spot the error.
Maybe you can see what I am missing...

ps: your proposed enum is also mixing things up and does not correspond to the datasheet.

1 reply

ki6syd Mar 29, 2024
Author

Running your latest commit on my board, it's properly muting/unmuting everything for me.

Maybe try alternating between muted/unmuted and see if there is a volume difference? I am finding that when I don't load the ES8388 output with a low impedance, it still has some output signal present even when muted. I'd guess the speaker amp on the AudioKit board has a high impedance input and is still amplifying something.

Sorry about that, I did give that enum the wrong name in the previous comment - It should be es_output_devicet and have the ES8388 prefix. I don't understand the need for _MIN, _SPK, _MAX so I left those alone. What about the datasheet do you see as an issue for LOUT1, LOUT2, ROUT1, ROUT2? Bits 0/1 of the register are unused in the datasheet I linked on the original post.

typedef enum {
  ES8388_OUTPUT_MIN = -1,
  ES8388_OUTPUT_LOUT1 = 0x20,
  ES8388_OUTPUT_ROUT1 = 0x08,
  ES8388_OUTPUT_SPK   = 0x09,
  ES8388_OUTPUT_LOUT2 = 0x10,
  ES8388_OUTPUT_ROUT2 = 0x04,
  ES8388_OUTPUT_ALL = 0x3c,
  ES8388_OUTPUT_MAX,
} es_output_device_t;

pschatzmann · 2024-03-29T11:29:51Z

pschatzmann
Mar 29, 2024
Maintainer

In my latest commit, I made sure, that the line number matches with the board definition: LINE1 goes now to LOUT1 and ROUT1.
When the line 0 is muted, I am now also switching off the PA, to make the setMute(mute, line); work on the AudioKit board!

This behavior can be configured in the new AudioDriverConfig.h

0 replies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DriverConstants.h Question: es_output_device_t #21

{{title}}

Replies: 5 comments 5 replies

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{editor}}'s edit

{{editor}}'s edit

Select a reply

DriverConstants.h Question: es_output_device_t #21

ki6syd Mar 26, 2024

Replies: 5 comments · 5 replies

pschatzmann Mar 26, 2024 Maintainer

ki6syd Mar 27, 2024 Author

ki6syd Mar 28, 2024 Author

pschatzmann Mar 27, 2024 Maintainer

ki6syd Mar 27, 2024 Author

pschatzmann Mar 27, 2024 Maintainer

ki6syd Mar 28, 2024 Author

pschatzmann Mar 28, 2024 Maintainer

ki6syd Mar 29, 2024 Author

pschatzmann Mar 29, 2024 Maintainer

ki6syd
Mar 26, 2024

Replies: 5 comments 5 replies

pschatzmann
Mar 26, 2024
Maintainer

ki6syd Mar 27, 2024
Author

ki6syd Mar 28, 2024
Author

pschatzmann
Mar 27, 2024
Maintainer

ki6syd Mar 27, 2024
Author

pschatzmann
Mar 27, 2024
Maintainer

ki6syd Mar 28, 2024
Author

pschatzmann
Mar 28, 2024
Maintainer

ki6syd Mar 29, 2024
Author

pschatzmann
Mar 29, 2024
Maintainer