You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This isn't an issue per-say but worth mentioning it in the article as it could be over looked. The LazyMinter.js has to live on the backend and the minter has to be a private key that lives on the backend. This isn't immediately obvious. So the minter (backend private key) would sign the voucher. Someone might read the article and think the signer used in the LazyMinter.js is the creator which would live on the frontend in Metamask for example. I know this is stated in LazyMinter.js but it's easily over looked.
A little block explaining that its a backend key (minter) that signs vouchers would be nice. I had to look at the unit tests to realise that the minter was signer and reach the above conclusion.
I also think the creator should be added to the voucher.
Right now the "creator" would be the minter which isn't actually true. This all assumes that we want some third party (a marketplace like opensea) to deploy the LazyNFT.sol and not the creator because alas if the creator has to deploy LazyNFT.sol it wouldn't be saving them money.
The text was updated successfully, but these errors were encountered:
Hi
This isn't an issue per-say but worth mentioning it in the article as it could be over looked. The
LazyMinter.js
has to live on the backend and theminter
has to be a private key that lives on the backend. This isn't immediately obvious. So the minter (backend private key) would sign the voucher. Someone might read the article and think the signer used in theLazyMinter.js
is the creator which would live on the frontend in Metamask for example. I know this is stated inLazyMinter.js
but it's easily over looked.A little block explaining that its a backend key (minter) that signs vouchers would be nice. I had to look at the unit tests to realise that the minter was signer and reach the above conclusion.
I also think the creator should be added to the voucher.
then
_mint(voucher.creator, voucher.tokenId);
Right now the "creator" would be the minter which isn't actually true. This all assumes that we want some third party (a marketplace like opensea) to deploy the
LazyNFT.sol
and not the creator because alas if the creator has to deployLazyNFT.sol
it wouldn't be saving them money.The text was updated successfully, but these errors were encountered: