Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default m2n exchange directory to parent directory #2089

Open
fsimonis opened this issue Oct 2, 2024 · 1 comment
Open

Change default m2n exchange directory to parent directory #2089

fsimonis opened this issue Oct 2, 2024 · 1 comment
Labels
breaking change Breaks backwards compatibility and users need to act configuration Related to the preCICE configuration usability This issue will make preCICE easier for non-expert users

Comments

@fsimonis
Copy link
Member

fsimonis commented Oct 2, 2024

Please describe the problem you are trying to solve.

While working on #2087 I realized that the default of the exchange directory of the m2n is the current working directory.

This makes writing integration tests easy, but is in direct conflict with how preCICE is used in practice.

To follow the proposed application case guidelines precice/preeco-orga#6 one always needs to use <m2n:... exchange-dir=".." />.

In the tutorials, every config specifies this.

Describe the solution you propose.

Change the default to exchange-dir="..".

This could be a breaking change. I am not sure if there is anyone using the default though.

Describe alternatives you've considered

Keep the default as the common working directory.

@fsimonis fsimonis added usability This issue will make preCICE easier for non-expert users configuration Related to the preCICE configuration labels Oct 2, 2024
@uekerman
Copy link
Member

uekerman commented Oct 2, 2024

We should do this at some point (depending on what we agree on in the guidelines), but this is breaking in my opinion.

@uekerman uekerman added the breaking change Breaks backwards compatibility and users need to act label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Breaks backwards compatibility and users need to act configuration Related to the preCICE configuration usability This issue will make preCICE easier for non-expert users
Projects
None yet
Development

No branches or pull requests

2 participants