Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore whitespace while 2FA authentication #31362

Merged
merged 3 commits into from
Dec 31, 2024
Merged

Ignore whitespace while 2FA authentication #31362

merged 3 commits into from
Dec 31, 2024

Conversation

CuNO3
Copy link
Contributor

@CuNO3 CuNO3 commented Dec 31, 2024

Add .Trim() to handle spaces in 2FA code input

The account verification emails state "You can enter the code with or without spaces", but osu!lazer currently does not ignore spaces when inputting 2FA codes. This PR adds .Trim() to handle spaces in the input.

Changes:

  • Added .Trim() (Change code.NewValue to code.NewValue.Trim() in 2FA Textbox) to ignore spaces in 2FA code input

Testing:

  • Verified working when login on dev.ppy.sh

Note: If the current behaviour is intentional, please let me know and I'll close this PR.

@peppy peppy self-requested a review December 31, 2024 12:13
Copy link
Member

@peppy peppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't see any harm in this.

@peppy peppy merged commit b09a34c into ppy:master Dec 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants