You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the speed at which the metronome swings & the tick sample plays to 2x (or 3x when beat divisor is in triples mode) the speed when control is pressed, matching stable behavior.
Addresses one of the points made in #31263 (4. point in timing section)
looking at the videos attached, not sure how to feel about the metronome speeding up and the weight on the pendulum moving but the bpm number not changing at all... seems off
looking at the videos attached, not sure how to feel about the metronome speeding up and the weight on the pendulum moving but the bpm number not changing at all... seems off
normal sped up
Agree with the BPM also showing double. maybe 122 (244 audible) or something if we want to avoid any confusion, but I also think only showing the sped-up BPM is fine.
How about showing something like 122 (2x)? I feel like 122 (244 audible) could run out of space in that container quickly if the bpm is higher, as well as the change being not only audible but visual too given that the metronome swings faster.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the speed at which the metronome swings & the tick sample plays to 2x (or 3x when beat divisor is in triples mode) the speed when control is pressed, matching stable behavior.
Addresses one of the points made in #31263 (4. point in
timingsection)Example on regular beat divisor
2024-12-30.03-36-53.mp4
Example on 1/3 beat divisor
2024-12-30.03-55-30.mp4