Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZPAQ TODO: Get show_progress to work on compression #4

Open
pete4abw opened this issue Apr 10, 2020 · 3 comments
Open

ZPAQ TODO: Get show_progress to work on compression #4

pete4abw opened this issue Apr 10, 2020 · 3 comments
Labels
help wanted

Comments

@pete4abw
Copy link
Owner

In libzpaq.cpp: Compressor::compress(int n)

/* TODO
 * Need to show progress
      // ver 7.15 uses read instead of get
      // need to show progresss in this way
      if (!(i % 128))
              show_progress(i);
*/

show_progress is defined in libzpaq.h in the lrzip block at the end.
@pete4abw
Copy link
Owner Author

The issue is that the StringBuffer class and LZBuffer class are used, and they use the read(n) function, not get(). While overriding StringBuffer works for read, for zpaq levels <= 3, the LZBuffer::read(n) function is used. Some logic will be needed to have the correct read function called.

@pete4abw
Copy link
Owner Author

pete4abw commented Jul 7, 2022

No help, no interest. Closing

@pete4abw pete4abw closed this as completed Jul 7, 2022
@pete4abw
Copy link
Owner Author

I'm reopening this since it is really bugging me. A recent change to the printing of ZPAQ progress spurred this. If -vv is used, no ZPAQ progress will be shown. The challenge is to remove the progress printing out of the get() function and into its own. More to come. Feel free to help out.

@pete4abw pete4abw reopened this Feb 27, 2023
@pete4abw pete4abw mentioned this issue Jul 7, 2023
Closed
@huanglei3 huanglei3 mentioned this issue Aug 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pete4abw