improved detection of countries #80
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I got the list of countries from here https://gist.github.com/kalinchernev/486393efcca01623b18d and it's not the best list ever (contains abbreviations and other additional tokens) but I wanted a list that was sourced from outside our existing dictionaries. |
|
Hmm... in hindsight this isn't quite right, for instance I put |
|
Yep, same thing for Luxembourg ^^" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this issue today over at libpostal and we have the same problem for users specifying 'Korea' instead of 'South Korea' or 'North Korea'.
I went ahead and added a bunch of tests and tried to improve country detection where possible but I didn't have time to fix all the test cases, so some are commented out for now.