'value' was interpolated in a string for attribute_condition call (AR

2.3.2 part) This was a mistake, getting SQL like "column = NULL" instead of "column IS NULL". Signed-off-by: Pete Deffendol <pete@mdsc.com>
pdeffendol · Jun 24, 2009 · f90868c · f90868c
1 parent a7e18f1
commit f90868c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/mysql_spatial_adapter.rb b/lib/mysql_spatial_adapter.rb
@@ -73,7 +73,7 @@ def self.get_rails2_conditions(attrs)
             table_name = quoted_table_name
           end
            begin # this works in AR 2.3.2 and later versions, it might work in earlier versions - this way of checking avoids using version numbers
-            attribute_condition("#{table_name}.#{connection.quote_column_name(attr)}", "#{value}") 
+            attribute_condition("#{table_name}.#{connection.quote_column_name(attr)}", value) 
            rescue ArgumentError # for some earlier versions of AR it definitely breaks
              "#{table_name}.#{connection.quote_column_name(attr)} #{attribute_condition(value)}" 
            end 

diff --git a/lib/post_gis_adapter.rb b/lib/post_gis_adapter.rb
@@ -58,7 +58,7 @@ def self.get_conditions(attrs)
           end
         else
         begin # this works in AR 2.3.2 and later versions, it might work in earlier versions - this way of checking avoids using version numbers
-         attribute_condition("#{table_name}.#{connection.quote_column_name(attr)}", "#{value}") 
+         attribute_condition("#{table_name}.#{connection.quote_column_name(attr)}", value) 
          rescue ArgumentError # for some earlier versions of AR it definitely breaks
           "#{table_name}.#{connection.quote_column_name(attr)} #{attribute_condition(value)}" 
          end