Improve Linux experience for crank run --device
#36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For one developer, the device never disappears, even when the data disk is prepared; it's unclear whether this is always true on Linux.
If called too early the run will fail. Ideally, we'd know of a specific marker that the device is ready to run...
|
I'm curious whether the "press 'A' to exit Data Disk mode" message is relevant on a Mac. The Playdate screen mentions ejecting, but ejecting on Linux doesn't exit Data Disk mode; does it on Mac? Do you have to press 'A' every time? If not, I could make that message Linux-specific. |
|
On Mac, neither message is needed, and the "Press 'A'" message never appears. I would like if you made both messages conditionally to only when not running on Mac. I think it would also be good to bump the crank package version number, as at least in the past one needed to use install --force to reinstall the same version. |
The message on the Playdate screen isn't as clear as it could be for newer developers. A message from crank makes it clearer that we're waiting for their action. On Mac, and presumably Windows, Data Disk mode is exited automatically when the Playdate is ejected.
|
Thanks for the clarification! I made the messages Linux-only, and bumped the version. Testing looked the same. |
rtsuk
approved these changes
Feb 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses some of the comments in #12.
modem_pathto disappear after initiating data disk mode, since (at least for me) it remains available.pdutil run. Without a wait it was failing. I based this on the Windows case, but on my machine it required 1s instead of 500ms.For the last two items, I chose a
printlnrather than a log message because logging isn't enabled in crank by default - I didn't want to change the logging strategy and thought these would be helpful for newer users/developers.I confirmed that the simulator case still worked as expected, with no changes, and that the changes worked as described with
--device.(The eject error is a separate issue mentioned in #12.)
These changes are in the
cfg(unix)path, and so also affect Mac, but I don't have a Mac setup to test with - hoping for confirmation there.