Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Autogenerate videos for new/modified acceptance tests and include them in the PR description. #21636

Open
seanlip opened this issue Jan 5, 2025 · 0 comments
Labels
enhancement Label to indicate an issue is a feature/improvement Impact: Medium Will improve quality-of-life for at least 30% of users. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet.

Comments

@seanlip
Copy link
Member

seanlip commented Jan 5, 2025

Is your feature request related to a problem? Please describe.

If an acceptance test is modified, it should be audited. A useful tool for this is seeing what the updated acceptance test is actually testing.

Describe the solution (or solutions) you'd like

In a PR, if an acceptance test is modified, or a new acceptance test is added, then record a video for that test.

More specifically:

  • When a PR is opened and it changes or modifies the acceptance tests, then GitHub Actions should record a video when running those tests (see also [Feature Request]: Upload videos for failed e2e/acceptance tests. #21634 which is slightly related, in terms of introducing video-recording capability). It should then modify the original PR description and add an autogenerated section at the bottom listing the videos for the new and modified tests. It should also leave a comment on the PR thread saying what it has done, and asking reviewers to look at those videos.
  • If the description is subsequently changed, GitHub Actions should check that the links to the videos are still there. If not, it should either add them back, or trigger a re-run of the acceptance test to get its video and regenerate that section.

Note that it is preferable to embed the videos in the comment, rather than to just post the links.

Describe alternatives you've considered and rejected

An alternative to the above is to leave a comment on the PR (i.e. not modify the original PR description). However, such a comment can get lost easily in the general conversation, so modifying the original PR description seems like it might be better.

Additional context

No response

@seanlip seanlip added triage needed enhancement Label to indicate an issue is a feature/improvement and removed triage needed labels Jan 5, 2025
@seanlip seanlip added Impact: Medium Will improve quality-of-life for at least 30% of users. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. labels Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Label to indicate an issue is a feature/improvement Impact: Medium Will improve quality-of-life for at least 30% of users. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet.
Projects
Status: Todo
Development

No branches or pull requests

1 participant