Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ot-fct] fix access file from path defined in build parameter #11080

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

aashu216
Copy link
Contributor

When configuration file defined in build parameter(command line argument), ot-fct is wouldn't take into an account and accessed default path.

This commit fixes to access configuration file from path which is defined from build command line parameter. Also, it fixes some compilation issues while building from ot-br-posix.

@jwhui jwhui requested a review from zhanglongxia December 24, 2024 02:12
Copy link

size-report bot commented Dec 24, 2024

Size Report of OpenThread

Merging #11080 into main(173cb61).

name branch text data bss total
ot-cli-ftd main 472600 856 66116 539572
#11080 472600 856 66116 539572
+/- 0 0 0 0
ot-ncp-ftd main 441308 760 61344 503412
#11080 441308 760 61344 503412
+/- 0 0 0 0
libopenthread-ftd.a main 239722 95 39902 279719
#11080 239722 95 39902 279719
+/- 0 0 0 0
libopenthread-cli-ftd.a main 58922 0 8075 66997
#11080 58922 0 8075 66997
+/- 0 0 0 0
libopenthread-ncp-ftd.a main 32787 0 5924 38711
#11080 32787 0 5924 38711
+/- 0 0 0 0
ot-cli-mtd main 368104 760 50764 419628
#11080 368104 760 50764 419628
+/- 0 0 0 0
ot-ncp-mtd main 350804 760 46008 397572
#11080 350804 760 46008 397572
+/- 0 0 0 0
libopenthread-mtd.a main 160218 0 24566 184784
#11080 160218 0 24566 184784
+/- 0 0 0 0
libopenthread-cli-mtd.a main 40125 0 8059 48184
#11080 40125 0 8059 48184
+/- 0 0 0 0
libopenthread-ncp-mtd.a main 25561 0 5924 31485
#11080 25561 0 5924 31485
+/- 0 0 0 0
ot-cli-ftd-br main 559352 864 130996 691212
#11080 559352 864 130996 691212
+/- 0 0 0 0
libopenthread-ftd-br.a main 331281 100 104750 436131
#11080 331281 100 104750 436131
+/- 0 0 0 0
libopenthread-cli-ftd-br.a main 73119 0 8107 81226
#11080 73119 0 8107 81226
+/- 0 0 0 0
ot-rcp main 63072 564 20804 84440
#11080 63072 564 20804 84440
+/- 0 0 0 0
libopenthread-rcp.a main 9920 0 5060 14980
#11080 9920 0 5060 14980
+/- 0 0 0 0
libopenthread-radio.a main 19102 0 238 19340
#11080 19102 0 238 19340
+/- 0 0 0 0

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.56%. Comparing base (143ebbf) to head (46b3da7).
Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11080      +/-   ##
==========================================
+ Coverage   73.41%   74.56%   +1.14%     
==========================================
  Files         622      619       -3     
  Lines       96901    89926    -6975     
==========================================
- Hits        71142    67055    -4087     
+ Misses      25759    22871    -2888     

see 362 files with indirect coverage changes

tools/ot-fct/cli.cpp Outdated Show resolved Hide resolved
@aashu216
Copy link
Contributor Author

@zhanglongxia ,
Updated PR with addressed review comments.

Copy link
Contributor

@zhanglongxia zhanglongxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aashu216
Copy link
Contributor Author

@jwhui,
Can you please help to merge this pull request?

@aashu216
Copy link
Contributor Author

can someone help to merge this PR?

@zhanglongxia zhanglongxia requested a review from jwhui January 2, 2025 01:32
@jwhui jwhui changed the title [tools] fixed to access file from path defined in build parameter in ot-fct [ot-fct] fix access file from path defined in build parameter Jan 4, 2025
tools/ot-fct/cli.cpp Outdated Show resolved Hide resolved
…ot-fct

When configuration file defined in build parameter(command line argument),
ot-fct is wound't take into an account and accessed default path.

This commit fixes to access configuration file from path which is
defined from build commnand line parameter. Also, it fixes some
compilation issues while building from ot-br-posix.

Signed-off-by: ashish <ashish.vara@nxp.com>
@jwhui jwhui merged commit fdb8190 into openthread:main Jan 6, 2025
97 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants