Skip to content

Commit

Permalink
Ensure sign-in page background is uniform throughout the page (oauth2…
Browse files Browse the repository at this point in the history
…-proxy#1988)

* Ensure sign-in page background is uniform throughout the page

Configured banners that take up large amounts of space leave a gap of blank
background between where the body ends and the footer starts.  Fix this by
setting the style for the section containing the banner to match the body and
footer

* Add changelog entry

---------

Co-authored-by: Joel Speed <Joel.speed@hotmail.co.uk>
  • Loading branch information
corybolar and JoelSpeed authored Mar 5, 2023
1 parent e079c60 commit 1bb3fbc
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
- [#1927](https://github.com/oauth2-proxy/oauth2-proxy/pull/1927) Fix default scope settings for none oidc providers
- [#1951](https://github.com/oauth2-proxy/oauth2-proxy/pull/1951) Fix validate URL, check if query string marker (?) or separator (&) needs to be appended (@miguelborges99)
- [#1920](https://github.com/oauth2-proxy/oauth2-proxy/pull/1920) Make sure emailClaim is not overriden if userIDClaim is not set
- [#1988](https://github.com/oauth2-proxy/oauth2-proxy/pull/1988) Ensure sign-in page background is uniform throughout the page

# V7.4.0

Expand Down
2 changes: 1 addition & 1 deletion pkg/app/pagewriter/sign_in.html
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
</style>
</head>
<body class="has-background-light">
<section class="section">
<section class="section has-background-light">
<div class="box block sign-in-box has-text-centered">
{{ if .LogoData }}
<div class="block logo-box">
Expand Down

0 comments on commit 1bb3fbc

Please sign in to comment.