(fix) Make the order fields nullish in the order forms #2179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +5 B (0%) Total Size: 16.1 MB ℹ️ View Unchanged
|
denniskigen
approved these changes
Jan 11, 2025
|
LGTM. Thanks, @vasharma05. TIL: z.string().nullable().optional === z.string().nullish(). |
denniskigen
force-pushed
the
fix/make-fields-nullish
branch
from
25e8370 to
e974a0e
Compare
denniskigen
added a commit
that referenced
this pull request
Jan 14, 2025
* Make the reference number and instructions fields nullish * Minor tweaks --------- Co-authored-by: Dennis Kigen <kigen.work@gmail.com>
3 tasks
Muppasanipraneeth
pushed a commit
to Muppasanipraneeth/openmrs-esm-patient-chart
that referenced
this pull request
Jan 20, 2025
* Make the reference number and instructions fields nullish * Minor tweaks --------- Co-authored-by: Dennis Kigen <kigen.work@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR makes the reference field and Additional instructions fields in the order forms
nullish. Currently, theoptionalallowsundefinedfield value, but if the value of the field isnull, it throws theinvalid_typeerror. As per docs, nullish will accept bothundefinedandnullvalues for the fields.Screenshots
Before
Screen.Recording.2025-01-10.at.22.07.49.mov
###After
Screen.Recording.2025-01-10.at.22.09.20.mov
Related Issue
None
Other