(fix) O3-4302: Hide voided diagnoses in patient chart visits widget #2167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +41 B (0%) Total Size: 16.1 MB ℹ️ View Unchanged
|
denniskigen
approved these changes
Jan 13, 2025
Comment on lines
79
to
87
| .filter((diagnosis) => !diagnosis.voided) | ||
| .forEach((diagnosis: Diagnosis) => { | ||
| // Putting all the diagnoses in a single array. | ||
| diagnoses.push({ | ||
| diagnosis: diagnosis.display, | ||
| type: diagnosis.rank === 1 ? 'red' : 'blue', | ||
| rank: diagnosis.rank, | ||
| voided: diagnosis.voided, | ||
| }); |
There was a problem hiding this comment.
Suggested change
| .filter((diagnosis) => !diagnosis.voided) | |
| .forEach((diagnosis: Diagnosis) => { | |
| // Putting all the diagnoses in a single array. | |
| diagnoses.push({ | |
| diagnosis: diagnosis.display, | |
| type: diagnosis.rank === 1 ? 'red' : 'blue', | |
| rank: diagnosis.rank, | |
| voided: diagnosis.voided, | |
| }); | |
| const validDiagnoses = enc.diagnoses | |
| .filter((diagnosis: Diagnosis) => !diagnosis.voided) | |
| .map((diagnosis: Diagnosis) => ({ | |
| diagnosis: diagnosis.display, | |
| type: diagnosis.rank === 1 ? 'red' : 'blue', | |
| rank: diagnosis.rank, | |
| voided: diagnosis.voided, | |
| })); | |
| diagnoses.push(...validDiagnoses); |
Does this work just as well?
There was a problem hiding this comment.
yes it does, updated it
|
Unrelated, but can we also replace |
|
CC: @jayasanka-sack Worth thinking about in the re-working of this widget that we remove any voided DXes from the request altogether. |
denniskigen
changed the title
denniskigen
approved these changes
Jan 14, 2025
Muppasanipraneeth
pushed a commit
to Muppasanipraneeth/openmrs-esm-patient-chart
that referenced
this pull request
Jan 20, 2025
…penmrs#2167) * (fix) O3-4302 Hide voided diagnosis in visits widget on patient chart * code review * Fixup --------- Co-authored-by: Dennis Kigen <kigen.work@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Hide voided diagnosis in visits widget on patient chart
Screenshots
Related Issue
Other