Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker image vulnerability fix #2088

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docker image vulnerability fix #2088

wants to merge 1 commit into from

Conversation

MartinJurcoGlina
Copy link
Collaborator

@MartinJurcoGlina MartinJurcoGlina commented Nov 6, 2024 •
edited
Loading

Checklist

  • I have followed (at least) the PR section of the contributing guide.
  • I fixed all necessary PR warnings
  • The commit history is clean
  • The E2E tests are passing
  • If possible, the issue has been divided into more subtasks
  • I did a self review before requesting a review from another team member

Description

  • bumped image version in e2e-tests

How to test

  1. <E.g. login as user XYZ>
  2. <E.g. try to create new subproject>
  3. <E.g. You should not see error in console>
  4. ...

Closes ModifyMe

@openkfwCI
Copy link

openkfwCI commented Nov 6, 2024 •
edited
Loading

NotesTime
✅Note for Reviewer: E2E tests on pipeline 60767 on remote server succeededWed, 06 Nov 2024 14:47:09 +0000

Generated by E2E-Test

SamuelPull
SamuelPull reviewed Nov 7, 2024
View reviewed changes
e2e-test/Dockerfile
@@ -1,4 +1,4 @@
FROM cypress/base:20.18.0
FROM cypress/base:22.11.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDK if we should upgrade to Node 22 just yet.
Cypress publishes 20.x.x and 22.x.x images regularly, first number means Node runtime.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, probably right, we can wait a bit for new minor version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamuelPull SamuelPull SamuelPull left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MartinJurcoGlina @openkfwCI @SamuelPull