Skip to content

Commit

Permalink
8343760: GHA: macOS / aarch64 builds depend on Xcode 14 which will be…
Browse files Browse the repository at this point in the history 
… removed

Reviewed-by: angorya
  • Loading branch information
@kevinrushforth
kevinrushforth committed Nov 8, 2024
1 parent fffa0fc commit d0011b2
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .github/workflows/submit.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,8 @@ jobs:
java -version
which ant
ant -version
sudo xcode-select --switch /Applications/Xcode_14.3.1.app/Contents/Developer
# We want to use Xcode 14, but GHA removed it from the macOS 14 runners
# sudo xcode-select --switch /Applications/Xcode_14.3.1.app/Contents/Developer
xcodebuild -version
- name: Build JavaFX artifacts
Expand Down

3 comments on commit d0011b2

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Issues

@kevinrushforth
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/backport jfx23u

@openjdk
Copy link

@openjdk openjdk bot commented on d0011b2 Nov 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevinrushforth the backport was successfully created on the branch backport-kevinrushforth-d0011b21-master in my personal fork of openjdk/jfx23u. To create a pull request with this backport targeting openjdk/jfx23u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit d0011b21 from the openjdk/jfx repository.

The commit being backported was authored by Kevin Rushforth on 8 Nov 2024 and was reviewed by Andy Goryachev.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jfx23u:

$ git fetch https://github.com/openjdk-bots/jfx23u.git backport-kevinrushforth-d0011b21-master:backport-kevinrushforth-d0011b21-master
$ git checkout backport-kevinrushforth-d0011b21-master
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jfx23u.git backport-kevinrushforth-d0011b21-master

Please sign in to comment.