Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix VideoCapture fails to read single image with digits in name #26637

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Fix VideoCapture fails to read single image with digits in name #26637

merged 3 commits into from
Dec 19, 2024

Conversation

MaximSmolskiy
Copy link
Contributor

Pull Request Readiness Checklist

Fix #26457

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov requested a review from mshabunin December 18, 2024 05:25
@asmorkalov asmorkalov added this to the 4.11.0 milestone Dec 18, 2024
@mshabunin
Copy link
Contributor

Could you please also add the test for this case?

@asmorkalov asmorkalov added the pr: needs test New functionality requires minimal tests set label Dec 18, 2024
@MaximSmolskiy
Copy link
Contributor Author

Could you please also add the test for this case?

@mshabunin Done

mshabunin
mshabunin approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@mshabunin mshabunin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@asmorkalov asmorkalov removed the pr: needs test New functionality requires minimal tests set label Dec 19, 2024
@asmorkalov asmorkalov merged commit 9f64f02 into opencv:4.x Dec 19, 2024
24 of 31 checks passed
@MaximSmolskiy MaximSmolskiy deleted the fix-VideoCapture-fails-to-read-single-image-with-digits-in-name branch December 19, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshabunin mshabunin mshabunin approved these changes

Assignees

@mshabunin mshabunin

Labels
bug category: videoio
Projects
None yet
Milestone
4.11.0
Development

Successfully merging this pull request may close these issues.

VideoCapture fails to read image sequences consisting of one single file that has digits in the file name
3 participants
@MaximSmolskiy @mshabunin @asmorkalov