Add some functions to OpenCV JS API #26387
Merged
+641
−453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sturkmen72
force-pushed
the
js-imgproc
branch
3 times, most recently
from
e87961b to
87c9acd
Compare
sturkmen72
force-pushed
the
js-imgproc
branch
2 times, most recently
from
cdb4049 to
8a28689
Compare
|
@asmorkalov Do we need to test for all the functions added? Are there any functions that need to be added from the list of unavailable functions? The functions added The functions below are still unavailable |
sturkmen72
changed the title
sturkmen72
force-pushed
the
js-imgproc
branch
2 times, most recently
from
d52540c to
8a02fea
Compare
|
The functions list is too long. I propose to add test for major functions and non-trivial interfaces. |
sturkmen72
force-pushed
the
js-imgproc
branch
5 times, most recently
from
07bda2d to
310587e
Compare
sturkmen72
force-pushed
the
js-imgproc
branch
4 times, most recently
from
39fae2a to
f4257a4
Compare
applyColorMap approxPolyN arrowedLine blendLinear boxPoints clipLine convertMaps createHanningWindow divSpectrums drawMarker findContoursLinkRuns fitEllipseAMS fitEllipseDirect getFontScaleFromHeight getRectSubPix HuMoments intersectConvexConvex invertAffineTransform minEnclosingTriangle preCornerDetect rotatedRectangleIntersection sqrBoxFilter spatialGradient stackBlur
sturkmen72
force-pushed
the
js-imgproc
branch
from
b0c8666 to
6eaa774
Compare
|
@asmorkalov please review. I've added the functions I consider most important and made some adjustments to enhance the code's readability and structure. I'll focus on adding more functions once this PR is merged. |
asmorkalov
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes : #20133
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.