feat(cli): add vi solidus / keybinding
#14908
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add keybinding for `/` when in vi normal mode which activates the history menu. - Make keybinding `mode` (`edit_mode`) case-insensitive.
tmillr
force-pushed
the
feat-vi-solidus-keybinding
branch
from
460da0d to
8276f84
Compare
tmillr
changed the title
/ keybinding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
/when in vi normal mode which activates the history menu.mode(edit_mode) case-insensitive.This keybinding exists both in vim and GNU Readline (e.g. bash) when in vi normal mode. The reason this keybinding is getting added here (and not in
reedline) is because it triggers the history menu, and should only be defined when the history menu exists. Menus are defined externally toreedline.User-Facing Changes
Added keybinding for
/when in vi normal mode which activates the history menu.Tests + Formatting
After Submitting
TODO: Update docs