Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lsp): better completion item documentation #14905

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Conversation

blindFS
Copy link
Contributor

@blindFS blindFS commented Jan 24, 2025

Description

This PR adds those markdown doc strings (previously only available via hover) to completion items:

image

It also refactors a bit, primarily to prevent namespace pollution.

User-Facing Changes

Tests + Formatting

After Submitting

@fdncred fdncred added the LSP Language Server Protocol (nu-lsp) label Jan 24, 2025
@fdncred fdncred merged commit 299453e into nushell:main Jan 24, 2025
15 checks passed
@fdncred
Copy link
Collaborator

fdncred commented Jan 24, 2025

Thanks. Appreciate all your LSP work here.

@github-actions github-actions bot added this to the v0.102.0 milestone Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LSP Language Server Protocol (nu-lsp)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants