Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parser): missing span of the entire block of a module file #14889

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

blindFS
Copy link
Contributor

@blindFS blindFS commented Jan 22, 2025

Description

A simple method found by @tmillr to solve this issue

User-Facing Changes

Tests + Formatting

I didn't find a suitable place in nu-parser to add the test case, placed in nu-lsp instead.

After Submitting

@fdncred
Copy link
Collaborator

fdncred commented Jan 22, 2025

looks good, thanks. let's see how it works out.

@fdncred fdncred merged commit 73c08fc into nushell:main Jan 22, 2025
15 checks passed
@github-actions github-actions bot added this to the v0.102.0 milestone Jan 22, 2025
@fdncred fdncred added the pr:bugfix This PR fixes some bug label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:bugfix This PR fixes some bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants