Jobs #14883
Draft
Jobs #14883
+364
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks interesting! by the way, if you haven't seen these PRs which also try to tackle background jobs, and might have some info on roadblocks you might run into. seems like the major blocker was the external printer in reedline. |
Yeah, the mentioned reedline output problems have already shown up. I'll have a look into it, thanks. |
This implementation still does not kill the job's current process if it is executing any, but already sends an interrupt through Signals which allows the job to be interrupted if it is running nushell code.
We still need to implement unfreezing it after suspending the program, and killing frozen jobs. TSTP a unix-specific thing, that could possibly be *emulated* in windows in the future, but for now, I think implementing this expected unix shell behaviour is a good call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an attempt to improve the nushell situation with regard to issue #247.
This PR aims to implement:
spawning jobs:
job spawn { do_background_thing }Jobs will be implemented as threads and not forks, to maintain a consistent behavior between unix and windows.
listing running jobs:
job listThis should allow users to list what background tasks they currently have running.
killing jobs:
job kill <id>This should send an interrupt to an existing job, and ideally, kill any process it is currently executing, if any.
Additionally this PR aims to provide means for nushell jobs to communicate with each other, with channels:
channel make,channel send, andchannel recvfor basic CSP operations.Things that should be taken into consideration for implementation:
TSTPsignals while executing code and turning the current program into a background job.Roadblocks encountered so far: